Conversation
Unsubmitted is not a valid Upstream-Status state, so update the patch to Inactive-Upstream, like all others. Fixes: 508e406 ("onl: update and fixup Upstream-Status tags") Signed-off-by: Jonas Gorski <jonas.gorski@bisdn.de>
${S} is set to ${WORKDIR}/git, so replace the explicit git/ in
destsuffix with ${S}. This makes the recipe more robust against upstream
changes.
Signed-off-by: Jonas Gorski <jonas.gorski@bisdn.de>
Newer Yocto versions complain about lack of whitespace around
assignment, so add the required whitespaces.
WARNING: .../poky/meta-open-network-linux/conf/machine/include/onl.inc:12 has a lack of whitespace around the assignment: 'ONL_PLATFORM="${@'${ONIE_ARCH}-${ONIE_MACHINE}'.replace('_', '-')}"'
Signed-off-by: Jonas Gorski <jonas.gorski@bisdn.de>
KanjiMonster
force-pushed
the
jogo_next_onl_cleanup
branch
from
002477d to
d373b2b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix minor issues in the onl recipe:
${S}instead ofgit/inSRC_URIUpstream-Status