allow termination mac entries without VID match#115
Draft
KanjiMonster wants to merge 2 commits intomainfrom
Draft
allow termination mac entries without VID match#115KanjiMonster wants to merge 2 commits intomainfrom
KanjiMonster wants to merge 2 commits intomainfrom
Conversation
KanjiMonster
changed the title
Collaborator
Author
|
We will also need this if we decide to add dummy interface support. |
When deleting termination mac entries for bridge interfaces, we need to make sure that we do strict matches, else we might also remove termination mac entries for the same mac for a specific port. Signed-off-by: Jonas Gorski <jonas.gorski@bisdn.de>
Allow termination mac entries to not check the VID so that they work regardless which VID is used for untagged traffic, and can be used for base port interfaces. Signed-off-by: Jonas Gorski <jonas.gorski@bisdn.de>
KanjiMonster
force-pushed
the
jogo_tmac_any_vid
branch
from
e46846b to
be289c6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The VID match is optional, so we shouldn't require it, like we don't require the port match.
To ensure that deletion does not delete more than the expected termination mac entries when removing those, switch the delete calls to _STRICT.
Signed-off-by: Jonas Gorski jonas.gorski@bisdn.de