Change contractual txid fields to strings in rpc.proto#131
Merged
ChrisSon15 merged 2 commits intobisq-network:mainfrom Mar 9, 2026
Merged
Conversation
Use strings instead of byte arrays in 'musigrpc.ContractualTxIds', as it is awkward for the Bisq2 client to reverse the bytes and convert to hex. Returning the raw txid bytes makes things no simpler on either end (even though it is arguably more consistent with the way other SHA256 hashes are represented in most of the protos).
Contributor
Author
|
I've just one more quick change to make in light of bisq-network/bisq2#4497 code review. |
Try to keep the field numbers in `rpc.proto` sequential (even though that breaks wire compatibility), as the corresponding change is being made in PR bisq-network/bisq2#4497 on the Bisq2 client side. Also add explicit 'optional' modifiers to message fields where they can be missing during normal usage of the 'Musig' service. (The modifier is technically redundant in those cases, and is just for clarity, as the fields have explicit presence and are already implicitly optional.)
stejbac
added a commit
to stejbac/bisq2
that referenced
this pull request
Mar 9, 2026
Reorder the field numbers in 'rpc.proto' to try to keep them sequential while still in development, even though that breaks wire compatibility. (The corresponding changes are being made on Rust side in PR bisq-network/bisq-musig#131.)
Contributor
Author
|
I've additionally reordered |
Collaborator
|
ACK |
stejbac
added a commit
to stejbac/bisq2
that referenced
this pull request
Mar 9, 2026
Reorder the field numbers in 'rpc.proto' to try to keep them sequential while still in development, even though that breaks wire compatibility. (The corresponding changes are being made on Rust side in PR bisq-network/bisq-musig#131.)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use strings instead of byte arrays in
musigrpc.ContractualTxIds, as it is awkward for the Bisq2 client to reverse the bytes and convert to hex. Returning the raw txid bytes makes things no simpler on either end (even though it is arguably more consistent with the way other SHA256 hashes are represented in most of the protos).