fix unreliable rpc tests due to race condition issue on get_available_port#132
Merged
ChrisSon15 merged 2 commits intobisq-network:mainfrom Mar 11, 2026
Merged
fix unreliable rpc tests due to race condition issue on get_available_port#132ChrisSon15 merged 2 commits intobisq-network:mainfrom
ChrisSon15 merged 2 commits intobisq-network:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix unreliable rpc tests due to race condition issue on get_available_port.
The function
get_available_portis dropping the temporary listener it creates.It could happen that before the caller bounds to the port another process does.
The solution here is to create the listener ourself and not delegating it to
get_available_portanymore and bind to the port before dropping the listener