fix: Respect symbolic toolbar icons as fallback #2345
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
buhtz
added
Qt
Member
Author
|
TODO: Add comment about this discussion and that this solution is a workaround and should be reverted if GNOME and/or Debian offer a long term solution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Symbolic icons now explicit used as fallback for icons in toolbar and elsewhere.
This is a workaround because Qt itself does ignore the concept of symbolic icons and does not check them by itself. This affects GNOME (Debian 13) users for example because it's adwaita icon theme is shipped with symbolic icons only.
Fix #2289