This repository was archived by the owner on Dec 30, 2022. It is now read-only.
Implemented custom validation in the Angular control#15
Open
ploutarchos wants to merge 4 commits intobitExpert:masterfrom
ploutarchos:master
Open
Implemented custom validation in the Angular control#15ploutarchos wants to merge 4 commits intobitExpert:masterfrom ploutarchos:master
ploutarchos wants to merge 4 commits intobitExpert:masterfrom
ploutarchos:master
Conversation
This works with both ngModel forms and Reactive Forms.
Member
|
Thanks for your contribution. We'll check the PR as soon as we can. |
It is not needed since styling of invalid status can now be achieved from the ng-invalid class that angular adds to the wrapper html element when the component becomes invalid.
Always initialise the list data to an empty array to fix a console error. Changed combo box to enforce a validation check on start up after the list data has been populated from the host component. This will always make the control invalid on start up, but at the same time it will be pristine and untouched. Changed combo box to generate two different validation errors "empty_input" and "input_no_match".
Member
|
We tested the PR with one of our sample projects but got an error. We need investigate a bit more what when wrong. Once we know, I'll let you know. |
Contributor
Author
|
What was the error you got? Also, what are the input properties you used in your app-combo-box? I tried it with the following ones, and I didn't get any error: In the Angular template (*.html) add this: In the Angular Component (*.ts) add this: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The combo-box will now validate whether the selected or typed value is a valid value (i.e. it matches to one of the items of the selection list). If it does, the control marks itself as valid, otherwise it becomes invalid.
A new input property has been introduced, the inputErrorClass to allow us format the input box when the control is marked as invalid.
This implementation works with both ngModel forms and Reactive Forms.
Note: The validation does not occur when remote data is being used. In that case, the control is always marked as invalid which is backwards compatible.