Fix crash when clicking on underlined property key#227
Merged
bitbrain merged 1 commit intobitbrain:godot-4.xfrom Jul 11, 2025
Merged
Conversation
shomykohai
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Normally, when clicking on a property key of an entity, Pandora will try to redirect to the definition of that property prompting to edit the key.
#202 introduced a regression, because Godot will try to focus the new properties and change screen at the same time, resulting in a call to a freed instance.
This PR ensures the new property is getting focused only when adding it from the property bar (as it should have been to begin with).
Addressed issues