Skip to content

Commit 0fa74ba

Browse files
committed
Merge #583: Meetings: add 2018-07-26
bdeeb8c Meetings: add 2018-07-26 (David A. Harding) Pull request description: Preview: http://dg1.dtrt.org/en/meetings/2018/07/26/ Tree-SHA512: 3a622ab919520eaa01e19efe813f0cb046c380ed9eace0edb0e15a9c82c3a24aa4f51bb46bf8bc57fa2f97770b71748b9f1d21b6dc255799ea46d898b3d92a99
2 parents 68f33d4 + bdeeb8c commit 0fa74ba

File tree

1 file changed

+182
-0
lines changed

1 file changed

+182
-0
lines changed
Lines changed: 182 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,182 @@
1+
---
2+
title: IRC meeting summary for 2018-07-26
3+
lang: en
4+
permalink: /en/meetings/2018/07/26/
5+
name: 2018-07-26-meeting
6+
layout: page
7+
type: meetings
8+
version: 1
9+
---
10+
{% include toc.html %}
11+
{% include references.md %}
12+
13+
- View this week's log on [BotBot.me][bbm log] or [MeetBot][mb log]
14+
- [Meeting minutes by MeetBot][mb minutes]
15+
16+
---
17+
18+
Topics discussed during this weekly meeting included the naming of an
19+
element in transactions spending segwit P2WSH outputs, the time of the
20+
weekly meeting, whether to create the final Git tag for the upcoming
21+
0.16.2 Bitcoin Core release, and an issue with encoding text strings on
22+
Windows.
23+
24+
## Naming of witness version of the P2SH redeemScript
25+
26+
**Background:** [BIP16][] P2SH provides a mechanism where you can
27+
receive a payment to the hash of a script. When you go to spend those
28+
bitcoins, you include the full script in the spend, where it's called a
29+
redeemScript. [BIP141][] segwit P2WSH uses almost the same mechanism but
30+
calls it witnessScript in BIP141. Unfortunately, there are several
31+
similar terms for ultimately different things that sound similar.
32+
33+
**Discussion ([log][log P2WSH redeemScript]):** Matt Corallo requested
34+
the topic and introduced it: "We have to pick [a term] for
35+
BitcoinCore.org [...] I know people who've called it the witness redeem
36+
script or so, which is also confusing because of P2SH-wrapped segwit,
37+
but witnessScript is confusing given [that the Bitcoin Core internal
38+
variable name] `scriptWitness` refers to the whole witness."
39+
40+
Pieter Wuille suggested, "Perhaps it should be called P2WSH
41+
redeemScript, as it's arguably specific to P2WSH (P2WPKH doesn't have
42+
it, and future witness versions may not either)."
43+
44+
**Conclusion:** No explicit conclusion. Jonas Schnelli and Gregory
45+
Maxwell argued that the discussion wasn't that important, and the topic
46+
was soon changed. BitcoinCore.org [issue #581][bcco #581] is
47+
tracking the subject.
48+
49+
## Meeting time
50+
51+
**Background:** as mentioned in the [July 5th meeting][alt meet time],
52+
meeting participants were worried that possibly many Bitcoin Core
53+
contributors, particularly those in East Asia and Oceania, were unable
54+
to attend meetings because of timezone differences. A poll was
55+
conducted by Cory Fields to find optimal meeting times.
56+
57+
**Discussion ([log][log time]):** Bryan Bishop requested an update on
58+
the topic, which was provided by Cory Fields: "[The] poll closed at the
59+
end of last week's meeting. Winner: [the] current time. [Poll
60+
results.][time poll results]"
61+
62+
The current scheduled time is Thursday 19:00 UTC. The second most
63+
favored time was one hour earlier. There was some quick discussion
64+
about whether the results were biased towards the people currently
65+
attending meetings, but it was noted that efforts were made to engage
66+
all active Bitcoin Core contributors, including those who lived in time
67+
zones where the current meeting occurs very early in morning.
68+
69+
**Conclusion:** no explicit conclusion. It did not seem like the
70+
meeting time is being changed at the moment.
71+
72+
## 0.16.2 final
73+
74+
**Background:** contributors have been working on a [minor version
75+
release][maintenance release] numbered 0.16.2 that contains backported
76+
bug fixes and minor features.
77+
78+
**Discussion ([log][log 0.16.2]):** Wladimir van der Laan opened the
79+
discussion, "Release Candidate (RC) 2 was tagged [about] a week ago. I
80+
don't think any issues came up, so I think it's time to tag final."
81+
82+
Matt Corallo, Gregory Maxwell, Jonas Schnelli, Cory Fields, and João
83+
Barbossa supported the decision.
84+
85+
**Conclusion:** after the meeting, 0.16.2 was tagged.
86+
87+
## Encoding issue on Windows
88+
89+
**Background:** the Windows Application Program Interface (API) has
90+
different requirements for strings of text than the Linux, MacOS, and
91+
\*BSD APIs. As Pieter Wuille explained during the discussion,
92+
"[Windows] adopted unicode very early, [so] they picked a different
93+
encoding than what the rest of the world eventually ended up picking."
94+
This currently creates problems when Bitcoin Core needs to open files
95+
that contain non-Latin characters in their file names or directory
96+
names.
97+
98+
**Discussion ([log][log win encoding]):** Chun Kuan Lee linked to PR
99+
[#13426][], requested the topic, and introduced it, "is it allowable to
100+
add [a] `wmain` function?" This would add a different `main` function
101+
to Bitcoin Core just for Windows users that could work around
102+
Windows-specific platform problems.
103+
104+
Wladimir van der Laan replied, "I'd prefer not. I think we had multiple
105+
entry points at some point, with [a] special one for Windows, but this
106+
was cleaned up to just `main()` [...] I think #13426 is too big a
107+
change."
108+
109+
**Conclusion:** After some discussion and quick web searches about what
110+
exactly Windows supports, several contributors said they should take a
111+
closer look at PR #13426 to possibly make concrete suggestions for
112+
improvement.
113+
114+
## Minor topics
115+
116+
- **High priority for review:** instead of the [usual list][current
117+
high-priority PRs], reviewers are encouraged to focus on PRs and
118+
issues [tagged][tag 0.17] for the upcoming Bitcoin Core release 0.17.
119+
120+
## Humor
121+
122+
{% highlight text %}
123+
<gmaxwell> i hate strings
124+
<wumpus> so do I, but unfortunately they're needed for path names
125+
<cfields> windows strings cause 2x developer hate :(
126+
<luke-jr> they string us along?
127+
<cfields> luke-jr: i would characterize it that way, yes
128+
{% endhighlight %}
129+
130+
## Participants
131+
132+
| IRC nick | Name/Nym |
133+
|-----------------|---------------------------|
134+
| wumpus | [Wladimir van der Laan][] |
135+
| gmaxwell | [Gregory Maxwell][] |
136+
| sipa | [Pieter Wuille][] |
137+
| cfields | [Cory Fields][] |
138+
| BlueMatt | [Matt Corallo][] |
139+
| ken2812221 | [Chun Kuan Lee][] |
140+
| jonasschnelli | [Jonas Schnelli][] |
141+
| promag | [Joao Barbosa][] |
142+
| achow101 | [Andrew Chow][] |
143+
| kanzure | [Bryan Bishop][] |
144+
| provoostenator | [Sjors Provoost][] |
145+
| jamesob | [James O'Beirne][] |
146+
| luke-jr | [Luke Dashjr][] |
147+
| jtimon | [Jorge Timón][] |
148+
| jnewbery | [John Newbery][] |
149+
| nmnkgl | [Gleb Naumenko][] |
150+
151+
## Disclaimer
152+
153+
This summary was compiled without input from any of the participants in
154+
the discussion, so any errors are the fault of the summary author and
155+
not the discussion participants. In particular, quotes taken from the
156+
discussion had their capitalization, punctuation, and spelling modified
157+
to produce consistent sentences. Bracketed words and fragments, as well
158+
as background narratives and exposition, were added by the author of
159+
this summary and may have accidentally changed the meaning of some
160+
sentences. If you believe any quote was taken out of context, please
161+
[open an issue](https://github.com/bitcoin-core/bitcoincore.org/issues/new)
162+
and we will correct the mistake.
163+
164+
[bbm log]: https://botbot.me/freenode/bitcoin-core-dev/msg/102496404/
165+
[mb minutes]: http://www.erisian.com.au/meetbot/bitcoin-core-dev/2018/bitcoin-core-dev.2018-07-26-19.01.html
166+
167+
[current high-priority PRs]: https://github.com/bitcoin/bitcoin/projects/8
168+
169+
{% assign log = "http://www.erisian.com.au/meetbot/bitcoin-core-dev/2018/bitcoin-core-dev.2018-07-26-19.01.log.html" %}
170+
[mb log]: {{log}}
171+
[log p2wsh redeemscript]: {{log}}#l-16
172+
[log time]: {{log}}#l-46
173+
[log 0.16.2]: {{log}}#l-69
174+
[log win encoding]: {{log}}#l-120
175+
176+
[bcco #581]: https://github.com/bitcoin-core/bitcoincore.org/issues/581
177+
[alt meet time]: /en/meetings/2018/07/05/#alternating-meeting-time
178+
[time poll results]: https://civs.cs.cornell.edu/cgi-bin/results.pl?id=E_a80f9a69d20aab2a
179+
[maintenance release]: /en/lifecycle/#maintenance-releases
180+
[tag 0.17]: https://github.com/bitcoin/bitcoin/milestone/33
181+
182+
{% include link-to-issues.md issues="13426" %}

0 commit comments

Comments
 (0)