Add QRImageProvider #454
Add QRImageProvider #454
Conversation
goqusan
force-pushed
the
qrimageprovider
branch
2 times, most recently
from
b5da13d to
16a22cd
Compare
johnny9
left a comment
johnny9
left a comment
There was a problem hiding this comment.
Concept ACK
Just some whitespace fix before approval
MarnixCroes
left a comment
MarnixCroes
left a comment
There was a problem hiding this comment.
The QR-code is displayed and I'm able to scan it ✅
However, if I scan it with a mobile Bitcoin wallet it cannot process it?
Which wallet? I scanned with Zeus and it recognized it as an address to send to. I also checked sparrow and it also displays just a string containing the address in the QR code on the Receive tab. |
|
Does the QR code contain a BIP21 URI? If so, the default OS camera should be able to open the wallet as needed (if the wallet has registered for the |
I tried with Phoenix, Breez and Blue Wallet. Neither work. |
No, it does not. Should be amended in a follow up, I presume. |
154c8e6 qml: Use QRImage in RequestPayment (goqusan) c46517b qml: Add QRImage control (goqusan) 9e1f8a0 qml: Add QRImageProvider (goqusan) Pull request description: The `QRImageProvider` can be used to display QR codes in QML `Image`. The new control `QRImage` wraps the new provider in a convenient way. The `RequestPayment` page is updated to showcase `QRImage` usage. ACKs for top commit: johnny9: tACK 154c8e6 Tree-SHA512: eb4b57245943ca34495e10de6a2bc8e28a6d1148f5aa99d7150d48c2a49e9049c2c4d3b3a481780c9e55efa07c3caed45f18bb2f8aaa1c5bdb621cadadaa82df
154c8e6a260b2d223d6e0171911d44bae642abf8 qml: Use QRImage in RequestPayment (goqusan)
c46517b41272037a526f640f8fe231fac988d274 qml: Add QRImage control (goqusan)
9e1f8a00863cb2adc270acfa7d611ebc36d37197 qml: Add QRImageProvider (goqusan)
Pull request description:
The `QRImageProvider` can be used to display QR codes in QML `Image`.
The new control `QRImage` wraps the new provider in a convenient way.
The `RequestPayment` page is updated to showcase `QRImage` usage.
ACKs for top commit:
johnny9:
tACK 154c8e6a260b2d223d6e0171911d44bae642abf8
Tree-SHA512: eb4b57245943ca34495e10de6a2bc8e28a6d1148f5aa99d7150d48c2a49e9049c2c4d3b3a481780c9e55efa07c3caed45f18bb2f8aaa1c5bdb621cadadaa82df
5 participants
The
QRImageProvidercan be used to display QR codes in QMLImage.The new control
QRImagewraps the new provider in a convenient way.The
RequestPaymentpage is updated to showcaseQRImageusage.