Skip to content

Commit 30640f8

Browse files
committed
Merge #13680: [doc] Remove outdated comment about miner ignoring CPFP
db6eb90 [doc] Remove outdated comment about mining code ignoring CPFP (James O'Beirne) Pull request description: BlockAssembler chooses transactions on the basis of packages (which incorporate unconfirmed ancestors into feerate), so the specified RBF comment about mining code ignoring CPFP is out of date. Tree-SHA512: a4c1e60fee0a8f450526d565951187f869d000febce0eea8a8d2e18bb140c3c1b8602953d9dcab2d1e8d0c4fc8d392c67eb0773d67e52080d48e6b9bf13f9ee2
2 parents 4027ec1 + db6eb90 commit 30640f8

File tree

1 file changed

+5
-7
lines changed

1 file changed

+5
-7
lines changed

src/validation.cpp

Lines changed: 5 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -806,13 +806,11 @@ static bool AcceptToMemoryPoolWorker(const CChainParams& chainparams, CTxMemPool
806806
// be increased is also an easy-to-reason about way to prevent
807807
// DoS attacks via replacements.
808808
//
809-
// The mining code doesn't (currently) take children into
810-
// account (CPFP) so we only consider the feerates of
811-
// transactions being directly replaced, not their indirect
812-
// descendants. While that does mean high feerate children are
813-
// ignored when deciding whether or not to replace, we do
814-
// require the replacement to pay more overall fees too,
815-
// mitigating most cases.
809+
// We only consider the feerates of transactions being directly
810+
// replaced, not their indirect descendants. While that does
811+
// mean high feerate children are ignored when deciding whether
812+
// or not to replace, we do require the replacement to pay more
813+
// overall fees too, mitigating most cases.
816814
CFeeRate oldFeeRate(mi->GetModifiedFee(), mi->GetTxSize());
817815
if (newFeeRate <= oldFeeRate)
818816
{

0 commit comments

Comments
 (0)