Skip to content

Commit 4c24142

Browse files
committed
[validation] Remove comment about AcceptToMemoryPool()
"This logic is not necessary for memory pool transactions, as AcceptToMemoryPool already refuses previously-known transaction ids entirely." refers to the logic at https://github.com/bitcoin/bitcoin/blob/a206b0ea12eb4606b93323268fc81a4f1f952531/src/main.cpp#L484-L486, which was later removed in commit 450cbb0.
1 parent 5759fd1 commit 4c24142

File tree

1 file changed

+0
-2
lines changed

1 file changed

+0
-2
lines changed

src/validation.cpp

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1658,8 +1658,6 @@ bool CChainState::ConnectBlock(const CBlock& block, BlockValidationState& state,
16581658
// can be duplicated to remove the ability to spend the first instance -- even after
16591659
// being sent to another address.
16601660
// See BIP30, CVE-2012-1909, and http://r6.ca/blog/20120206T005236Z.html for more information.
1661-
// This logic is not necessary for memory pool transactions, as AcceptToMemoryPool
1662-
// already refuses previously-known transaction ids entirely.
16631661
// This rule was originally applied to all blocks with a timestamp after March 15, 2012, 0:00 UTC.
16641662
// Now that the whole chain is irreversibly beyond that time it is applied to all blocks except the
16651663
// two in the chain that violate it. This prevents exploiting the issue against nodes during their

0 commit comments

Comments
 (0)