doc: net_proc: reference past DoS vulnerability in orphan processing

darosior · darosior · commit 68ac9542c451 · 2025-02-12T15:10:27.000-05:00
diff --git a/src/net_processing.cpp b/src/net_processing.cpp
@@ -3072,6 +3072,8 @@ void PeerManagerImpl::ProcessPackageResult(const node::PackageToValidate& packag
     }
 }
 
+// NOTE: the orphan processing used to be uninterruptible and quadratic, which could allow a peer to stall the node for
+// hours with specially crafted transactions. See https://bitcoincore.org/en/2024/07/03/disclose-orphan-dos.
 bool PeerManagerImpl::ProcessOrphanTx(Peer& peer)
 {
     AssertLockHeld(g_msgproc_mutex);

Original file line number	Diff line number	Diff line change
`@@ -3072,6 +3072,8 @@ void PeerManagerImpl::ProcessPackageResult(const node::PackageToValidate& packag`
`3072`	`3072`	`}`
`3073`	`3073`	`}`
`3074`	`3074`
	`3075`	`+// NOTE: the orphan processing used to be uninterruptible and quadratic, which could allow a peer to stall the node for`
	`3076`	`+// hours with specially crafted transactions. See https://bitcoincore.org/en/2024/07/03/disclose-orphan-dos.`
`3075`	`3077`	`bool PeerManagerImpl::ProcessOrphanTx(Peer& peer)`
`3076`	`3078`	`{`
`3077`	`3079`	`AssertLockHeld(g_msgproc_mutex);`