Skip to content

Commit 944b21b

Browse files
committed
net: don't check if the socket is valid in ConnectSocketDirectly()
The socket is always valid (the underlying file descriptor is not `INVALID_SOCKET`) when `ConnectSocketDirectly()` is called.
1 parent aeac68d commit 944b21b

File tree

1 file changed

+0
-4
lines changed

1 file changed

+0
-4
lines changed

src/netbase.cpp

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -514,10 +514,6 @@ bool ConnectSocketDirectly(const CService &addrConnect, const Sock& sock, int nT
514514
// Create a sockaddr from the specified service.
515515
struct sockaddr_storage sockaddr;
516516
socklen_t len = sizeof(sockaddr);
517-
if (sock.Get() == INVALID_SOCKET) {
518-
LogPrintf("Cannot connect to %s: invalid socket\n", addrConnect.ToStringAddrPort());
519-
return false;
520-
}
521517
if (!addrConnect.GetSockAddr((struct sockaddr*)&sockaddr, &len)) {
522518
LogPrintf("Cannot connect to %s: unsupported network\n", addrConnect.ToStringAddrPort());
523519
return false;

0 commit comments

Comments
 (0)