Skip to content

Commit c79bf32

Browse files
committed
Merge #16625: scripts: remove github-merge.py
6c27fa0 scripts: remove github-merge.py (fanquake) Pull request description: This script has been moved to the bitcoin-core/bitcoin-maintainer-tools repository, after discussion in a core dev meeting. The rationale being that it is also useful to other projects, and thus should be moved to a more general repository. Meeting log: http://www.erisian.com.au/bitcoin-core-dev/log-2019-08-15.html See also: bitcoin-core/bitcoin-maintainer-tools#28 ~~I'll open a follow up PR to port the documentation to the maintainer tools repo.~~ Ported the docs in bitcoin-core/bitcoin-maintainer-tools#29 ACKs for top commit: laanwj: ACK 6c27fa0 Tree-SHA512: 972070c6893043aebe3b62118d2e42d857553202b1eeb9abca55326f580f25e9859de188a1d0c50b9c7d20bdeeddffc00bcf9ad5a76b60add5c8541956d45489
2 parents 27ee0cc + 6c27fa0 commit c79bf32

File tree

4 files changed

+3
-476
lines changed

4 files changed

+3
-476
lines changed

contrib/README.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,10 +3,10 @@ Repository Tools
33

44
### [Developer tools](/contrib/devtools) ###
55
Specific tools for developers working on this repository.
6-
Contains the script `github-merge.py` for merging GitHub pull requests securely and signing them using GPG.
6+
Additional tools, including the `github-merge.py` script, are available in the [maintainer-tools](https://github.com/bitcoin-core/bitcoin-maintainer-tools) repository.
77

88
### [Verify-Commits](/contrib/verify-commits) ###
9-
Tool to verify that every merge commit was signed by a developer using the above `github-merge.py` script.
9+
Tool to verify that every merge commit was signed by a developer using the `github-merge.py` script.
1010

1111
### [Linearize](/contrib/linearize) ###
1212
Construct a linear, no-fork, best version of the blockchain.

contrib/devtools/README.md

Lines changed: 0 additions & 60 deletions
Original file line numberDiff line numberDiff line change
@@ -89,66 +89,6 @@ example:
8989
BUILDDIR=$PWD/build contrib/devtools/gen-manpages.sh
9090
```
9191

92-
github-merge.py
93-
===============
94-
95-
A small script to automate merging pull-requests securely and sign them with GPG.
96-
97-
For example:
98-
99-
./github-merge.py 3077
100-
101-
(in any git repository) will help you merge pull request #3077 for the
102-
bitcoin/bitcoin repository.
103-
104-
What it does:
105-
* Fetch master and the pull request.
106-
* Locally construct a merge commit.
107-
* Show the diff that merge results in.
108-
* Ask you to verify the resulting source tree (so you can do a make
109-
check or whatever).
110-
* Ask you whether to GPG sign the merge commit.
111-
* Ask you whether to push the result upstream.
112-
113-
This means that there are no potential race conditions (where a
114-
pullreq gets updated while you're reviewing it, but before you click
115-
merge), and when using GPG signatures, that even a compromised GitHub
116-
couldn't mess with the sources.
117-
118-
Setup
119-
---------
120-
Configuring the github-merge tool for the bitcoin repository is done in the following way:
121-
122-
git config githubmerge.repository bitcoin/bitcoin
123-
git config githubmerge.testcmd "make -j4 check" (adapt to whatever you want to use for testing)
124-
git config --global user.signingkey mykeyid
125-
126-
Authentication (optional)
127-
--------------------------
128-
129-
The API request limit for unauthenticated requests is quite low, but the
130-
limit for authenticated requests is much higher. If you start running
131-
into rate limiting errors it can be useful to set an authentication token
132-
so that the script can authenticate requests.
133-
134-
- First, go to [Personal access tokens](https://github.com/settings/tokens).
135-
- Click 'Generate new token'.
136-
- Fill in an arbitrary token description. No further privileges are needed.
137-
- Click the `Generate token` button at the bottom of the form.
138-
- Copy the generated token (should be a hexadecimal string)
139-
140-
Then do:
141-
142-
git config --global user.ghtoken "pasted token"
143-
144-
Create and verify timestamps of merge commits
145-
---------------------------------------------
146-
To create or verify timestamps on the merge commits, install the OpenTimestamps
147-
client via `pip3 install opentimestamps-client`. Then, download the gpg wrapper
148-
`ots-git-gpg-wrapper.sh` and set it as git's `gpg.program`. See
149-
[the ots git integration documentation](https://github.com/opentimestamps/opentimestamps-client/blob/master/doc/git-integration.md#usage)
150-
for further details.
151-
15292
optimize-pngs.py
15393
================
15494

0 commit comments

Comments
 (0)