Defer transaction signing until user clicks Send #915
Conversation
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ReviewsSee the guideline for information on the review process.
If your review is incorrectly listed, please copy-paste ConflictsReviewers, this pull request conflicts with the following ones:
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first. |
hebasto
changed the title
|
It looks like the one failing check is a CI issue with disk space too low. I'm not sure how to address that. I think the code of the PR is correct. |
|
@achow101 would you like to check this out and let me know if it looks OK? |
|
Should I push an empty commit to trigger a re-run of the CI here, or is there some other action needed? |
No action needed. |
Fixes #30070 When creating an unsigned PSBT from the GUI, the transaction was already signed during preparation, causing legacy inputs to have non-empty scriptSig fields. The PSBT parser then rejects them. This defers signing until the user clicks "Send" instead of signing during preparation. Fee calculation still works since transactions can be created without signing. Follows the approach suggested by @achow101 in the issue comments.
151henry151
force-pushed
the
fix-30070-defer-signing
branch
from
58adbcf to
3c61ba5
Compare
5 participants
Fixes #30070
When creating an unsigned PSBT from the GUI, the transaction was already signed during preparation, causing legacy inputs to have non-empty scriptSig fields. The PSBT parser then rejects them.
This defers signing until the user clicks "Send" instead of signing during preparation. Fee calculation still works since transactions can be created without signing.
Follows the approach suggested by @achow101 in the issue comments.