Skip to content

Conversation

@ryanofsky
Copy link
Collaborator

Increase version number after previous version was added to bitcoin core. Also update version history and documentation.

Increase version number after previous version was added to bitcoin core. Also
update version history and documentation.
@DrahtBot
Copy link

DrahtBot commented Jan 21, 2026

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Reviews

See the guideline for information on the review process.

Type Reviewers
ACK Sjors

If your review is incorrectly listed, please copy-paste <!--meta-tag:bot-skip--> into the comment that the bot should ignore.

@ryanofsky
Copy link
Collaborator Author

Note: a good followup for this PR would be to port willcl-ark's change bitcoin/bitcoin#33623 from the 29.x branch to the 30.x and master branches, adding libmultiprocess and capnproto version information to the dependencies documents:

@ryanofsky
Copy link
Collaborator Author

Updated 34c3d04 -> 0ade1b4 (pr/v8.3 -> pr/v8.4, compare) to fix llm typos

@Sjors
Copy link
Member

Sjors commented Jan 22, 2026

If I understand correctly 7.0-pre1 are all in Bitcoin Core 30.x, while 7.0 changes will go in 31.x, unless they're backported. So I guess we should have bumped the version earlier? Since the version is encoded in MP_MAJOR_VERSION we can't retroactively adjust the tags.

ACK 0ade1b4

I did not check the PR links to earlier subtree updates.

@ryanofsky
Copy link
Collaborator Author

Thanks for the review!

Since the version is encoded in MP_MAJOR_VERSION we can't retroactively adjust the tags.

Exactly yes. I added the v5.0-pre1 tag when I wanted to tag a version between v4.0 and v5.0 and I added a v7.0-pre1 tag when I wanted to tag a version between v6.0 and v7.0. This seemed less awkward than renumbering due to MP_MAJOR_VERSION being present. In the future, it shouldn't be necessary to have any more -pre tags as long as the version number is bumped consistently. When I initially created the v0..v7 tags, I just didn't create enough of them and didn't leave space between them.

@ryanofsky ryanofsky merged commit 3a69d47 into bitcoin-core:master Jan 22, 2026
10 checks passed
@Sjors
Copy link
Member

Sjors commented Jan 22, 2026

and didn't leave space between them.

Oh this brings back memories of BASIC line numbering...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants