Add shebang to delete_nonreduced_fuzz_inputs.sh#268
Add shebang to delete_nonreduced_fuzz_inputs.sh#268ekzyis wants to merge 1 commit intobitcoin-core:mainfrom
Conversation
b856d11 to
e8f063b
Compare
Thanks for working on this, and sorry for not reviewing that earlier, but I think Bash or Python are the wrong answer to long-running scripts, because inherently there will be an accidental typo (none vs None) or a type confusion string vs array (or syntax question like yours), which will only be discovered at run-time, possibly after waiting (wasting) hours. I think such long-running scripts should be written in a compiled language. So my recommendation would be to first re-write the existing Bash script to Rust. I wanted to do this last week, but I didn't get to it yet. |
|
edit: See https://github.com/bitcoin/bitcoin/blob/master/contrib/devtools/deterministic-unittest-coverage/src/main.rs for an example template for a main.rs that could be used as a style guide. |
No worries! I didn't expect any review, since it's still a draft.
Oh, yes, I agree! A compiled language would have helped with many conceptually small, yet time-consuming issues for shell reasons ("can I use arrays?", I'll see what I can do, but I might not get to it this week. So don't feel blocked by me, if you happen to have time. |
The script uses array features like
readarrayand the[@]syntax. Afaik, these requirebash, see manual.While working on #266, I wasn't sure if I can assume
bashand use syntax likeREFS=("master").I created this PR to get this question out of the way.