Drop src/libsecp256k1-config.h
#1178
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change eases the use of alternate build systems by moving the variables in `src/libsecp256k1-config.h` to compiler macros for each invocation, preventing duplication of these variables for each build system. Co-authored-by: Ali Sherief <[email protected]>
hebasto
force-pushed
the
221214-config
branch
from
e129a39 to
ad8647f
Compare
|
Not sure about this secp256k1/build-aux/m4/bitcoin_secp.m4 Line 23 in 9a8d65f |
I suggest removing it, it's unused, and also confusing because we use the |
Done. |
|
utACK 9c5a4d2 |
| @@ -148,7 +148,7 @@ endif | |||
| if USE_EXAMPLES | |||
| noinst_PROGRAMS += ecdsa_example | |||
| ecdsa_example_SOURCES = examples/ecdsa.c | |||
| ecdsa_example_CPPFLAGS = -I$(top_srcdir)/include | |||
| ecdsa_example_CPPFLAGS = -I$(top_srcdir)/include $(SECP_CONFIG_DEFINES) | |||
There was a problem hiding this comment.
Shouldn't these be dropped for the example, because a user application shouldn't need our defines?
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-picked the first commit from #1142 and addressed a comment.