Be stricter with side effects in VERIFY #1485
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
real-or-random
added
assurance
tweak/refactor
meta/development
real-or-random
commented
Jan 17, 2024
| size_t i_ver; | ||
| for (i_ver = 0; i_ver < len; i_ver++) { | ||
| SECP256K1_GE_VERIFY(&r[i_ver]); | ||
| } | ||
| } | ||
| #endif |
There was a problem hiding this comment.
These loops caught my attention initially. Here we set i inside VERIFY block, but we also use it outside. I think this should be avoided out of an abundance of caution.
real-or-random
force-pushed
the
202401-i-side-effect
branch
from
a24dd53 to
690a890
Compare
khademreza5
approved these changes
Jan 17, 2024
real-or-random
force-pushed
the
202401-i-side-effect
branch
from
690a890 to
f65f1a4
Compare
real-or-random
force-pushed
the
202401-i-side-effect
branch
from
f65f1a4 to
f3b91f0
Compare
|
thanks, rebased. |
theStack
approved these changes
Jun 26, 2024
Adds a rule to CONTRIBUTING.md and makes the code adhere to it.
real-or-random
force-pushed
the
202401-i-side-effect
branch
from
f3b91f0 to
ee7083f
Compare
gatleas17
approved these changes
Aug 4, 2024
stratospher
reviewed
Feb 24, 2025
There was a problem hiding this comment.
ACK ee7083f. if you retouch - few more places in the musig module needs to be updated with this pattern too.
real-or-random
added a commit
to real-or-random/secp256k1
that referenced
this pull request
Aug 19, 2025
This is slightly more pedantic because it avoids suppressing the warning value when not necessary, and I find it more readable. And it matches our current conventions, see for example secp256k1_ellswift_xswiftec_inv_var and see also my PR bitcoin-core#1485 (which I should rebase...)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a rule to CONTRIBUTING.md and makes the code adhere to it.