Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds sse2 and avx2 support to the library in general, as discussed in #1700, wherever it yields an improvement as per the benchmarks.
arm has different SIMD instruction set; it would be nice to have a separate PR implementing that as well. Maybe after this is merged...
Tasks:
-msse2
,-mno-sse2
when building for amd32-mavx2
,-msse2
,-mno-avx2
,-mno-sse2
when building for amd64TODO: precompute
)Test & Benchmark
To reproduce the following results I temporarily added 3 scripts for building, testing, benchmarking as well as a jupyter notebook to visualize results.
You can verify yourself by running:
./simd-build.sh && ./simd-test.sh && ./simd-bench.sh
and executing the notebook as is.Results