-
Notifications
You must be signed in to change notification settings - Fork 1.1k
ci: DRY workflow using anchors #1719
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
hebasto
wants to merge
4
commits into
bitcoin-core:master
Choose a base branch
from
hebasto:250807-yaml-anchors
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
50e73c6
ci: Use YAML anchor and aliases for repeated "Checkout" steps
hebasto ef3b514
ci: Use YAML anchor and aliases for repeated "Print logs" steps
hebasto dcaf102
ci, refactor: Generalize use of `matrix.configuration.env_vars`
hebasto 8729f4e
ci: Use YAML anchor and aliases for repeated "CI script" steps
hebasto File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||||||
|---|---|---|---|---|---|---|---|---|---|---|
|
|
@@ -108,17 +108,20 @@ jobs: | |||||||||
| CC: ${{ matrix.cc }} | ||||||||||
|
|
||||||||||
| steps: | ||||||||||
| - name: Checkout | ||||||||||
| - &checkout | ||||||||||
| name: Checkout | ||||||||||
| uses: actions/checkout@v4 | ||||||||||
|
|
||||||||||
| - name: CI script | ||||||||||
| - &x64_ci_script | ||||||||||
| name: CI script | ||||||||||
| env: ${{ matrix.configuration.env_vars }} | ||||||||||
| uses: ./.github/actions/run-in-docker-action | ||||||||||
| with: | ||||||||||
| dockerfile: ./ci/linux-debian.Dockerfile | ||||||||||
| tag: x64-debian-image | ||||||||||
|
|
||||||||||
| - name: Print logs | ||||||||||
| - &print-logs | ||||||||||
| name: Print logs | ||||||||||
| uses: ./.github/actions/print-logs | ||||||||||
| if: ${{ !cancelled() }} | ||||||||||
|
|
||||||||||
|
|
@@ -130,6 +133,8 @@ jobs: | |||||||||
| strategy: | ||||||||||
| fail-fast: false | ||||||||||
| matrix: | ||||||||||
| configuration: | ||||||||||
| - env_vars: {} | ||||||||||
| cc: | ||||||||||
| - 'i686-linux-gnu-gcc' | ||||||||||
| - 'clang --target=i686-pc-linux-gnu -isystem /usr/i686-linux-gnu/include' | ||||||||||
|
|
@@ -145,24 +150,20 @@ jobs: | |||||||||
| CC: ${{ matrix.cc }} | ||||||||||
|
|
||||||||||
| steps: | ||||||||||
| - name: Checkout | ||||||||||
| uses: actions/checkout@v4 | ||||||||||
|
|
||||||||||
| - name: CI script | ||||||||||
| uses: ./.github/actions/run-in-docker-action | ||||||||||
| with: | ||||||||||
| dockerfile: ./ci/linux-debian.Dockerfile | ||||||||||
| tag: x64-debian-image | ||||||||||
|
|
||||||||||
| - name: Print logs | ||||||||||
| uses: ./.github/actions/print-logs | ||||||||||
| if: ${{ !cancelled() }} | ||||||||||
| - *checkout | ||||||||||
| - *x64_ci_script | ||||||||||
| - *print-logs | ||||||||||
|
|
||||||||||
| s390x_debian: | ||||||||||
| name: "s390x (big-endian): Linux (Debian stable, QEMU)" | ||||||||||
| runs-on: ubuntu-latest | ||||||||||
| needs: docker_cache | ||||||||||
|
|
||||||||||
| strategy: | ||||||||||
| matrix: | ||||||||||
| configuration: | ||||||||||
| - env_vars: {} | ||||||||||
|
|
||||||||||
|
Comment on lines
+162
to
+166
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Adding an empty matrix configuration with just 'env_vars: {}' appears to serve no functional purpose for the s390x_debian job. This adds unnecessary complexity without providing the matrix benefits that other jobs use.
Suggested change
Copilot uses AI. Check for mistakes. Positive FeedbackNegative Feedback |
||||||||||
| env: | ||||||||||
| WRAPPER_CMD: 'qemu-s390x' | ||||||||||
| SECP256K1_TEST_ITERS: 16 | ||||||||||
|
|
@@ -177,19 +178,9 @@ jobs: | |||||||||
| CTIMETESTS: 'no' | ||||||||||
|
|
||||||||||
| steps: | ||||||||||
| - name: Checkout | ||||||||||
| uses: actions/checkout@v4 | ||||||||||
|
|
||||||||||
| - name: CI script | ||||||||||
| uses: ./.github/actions/run-in-docker-action | ||||||||||
| with: | ||||||||||
| dockerfile: ./ci/linux-debian.Dockerfile | ||||||||||
| tag: x64-debian-image | ||||||||||
|
|
||||||||||
| - name: Print logs | ||||||||||
| uses: ./.github/actions/print-logs | ||||||||||
| if: ${{ !cancelled() }} | ||||||||||
|
|
||||||||||
| - *checkout | ||||||||||
| - *x64_ci_script | ||||||||||
| - *print-logs | ||||||||||
|
|
||||||||||
| arm32_debian: | ||||||||||
| name: "ARM32: Linux (Debian stable, QEMU)" | ||||||||||
|
|
@@ -217,19 +208,9 @@ jobs: | |||||||||
| CTIMETESTS: 'no' | ||||||||||
|
|
||||||||||
| steps: | ||||||||||
| - name: Checkout | ||||||||||
| uses: actions/checkout@v4 | ||||||||||
|
|
||||||||||
| - name: CI script | ||||||||||
| env: ${{ matrix.configuration.env_vars }} | ||||||||||
| uses: ./.github/actions/run-in-docker-action | ||||||||||
| with: | ||||||||||
| dockerfile: ./ci/linux-debian.Dockerfile | ||||||||||
| tag: x64-debian-image | ||||||||||
|
|
||||||||||
| - name: Print logs | ||||||||||
| uses: ./.github/actions/print-logs | ||||||||||
| if: ${{ !cancelled() }} | ||||||||||
| - *checkout | ||||||||||
| - *x64_ci_script | ||||||||||
| - *print-logs | ||||||||||
|
|
||||||||||
| arm64-debian: | ||||||||||
| name: "arm64: Linux (Debian stable)" | ||||||||||
|
|
@@ -258,24 +239,26 @@ jobs: | |||||||||
| - 'clang-snapshot' | ||||||||||
|
|
||||||||||
| steps: | ||||||||||
| - name: Checkout | ||||||||||
| uses: actions/checkout@v4 | ||||||||||
| - *checkout | ||||||||||
|
|
||||||||||
| - name: CI script | ||||||||||
| uses: ./.github/actions/run-in-docker-action | ||||||||||
| with: | ||||||||||
| dockerfile: ./ci/linux-debian.Dockerfile | ||||||||||
| tag: arm64-debian-image | ||||||||||
|
|
||||||||||
| - name: Print logs | ||||||||||
| uses: ./.github/actions/print-logs | ||||||||||
| if: ${{ !cancelled() }} | ||||||||||
| - *print-logs | ||||||||||
|
|
||||||||||
| ppc64le_debian: | ||||||||||
| name: "ppc64le: Linux (Debian stable, QEMU)" | ||||||||||
| runs-on: ubuntu-latest | ||||||||||
| needs: docker_cache | ||||||||||
|
|
||||||||||
| strategy: | ||||||||||
| matrix: | ||||||||||
| configuration: | ||||||||||
| - env_vars: {} | ||||||||||
|
|
||||||||||
|
Comment on lines
+257
to
+261
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Adding an empty matrix configuration with just 'env_vars: {}' appears to serve no functional purpose for the ppc64le_debian job. This adds unnecessary complexity without providing the matrix benefits that other jobs use.
Suggested change
Copilot uses AI. Check for mistakes. Positive FeedbackNegative Feedback |
||||||||||
| env: | ||||||||||
| WRAPPER_CMD: 'qemu-ppc64le' | ||||||||||
| SECP256K1_TEST_ITERS: 16 | ||||||||||
|
|
@@ -290,19 +273,9 @@ jobs: | |||||||||
| CTIMETESTS: 'no' | ||||||||||
|
|
||||||||||
| steps: | ||||||||||
| - name: Checkout | ||||||||||
| uses: actions/checkout@v4 | ||||||||||
|
|
||||||||||
| - name: CI script | ||||||||||
| uses: ./.github/actions/run-in-docker-action | ||||||||||
| with: | ||||||||||
| dockerfile: ./ci/linux-debian.Dockerfile | ||||||||||
| tag: x64-debian-image | ||||||||||
|
|
||||||||||
| - name: Print logs | ||||||||||
| uses: ./.github/actions/print-logs | ||||||||||
| if: ${{ !cancelled() }} | ||||||||||
|
|
||||||||||
| - *checkout | ||||||||||
| - *x64_ci_script | ||||||||||
| - *print-logs | ||||||||||
|
|
||||||||||
| valgrind_debian: | ||||||||||
| name: "Valgrind ${{ matrix.binary_arch }} (memcheck)" | ||||||||||
|
|
@@ -352,8 +325,7 @@ jobs: | |||||||||
| SECP256K1_TEST_ITERS: 2 | ||||||||||
|
|
||||||||||
| steps: | ||||||||||
| - name: Checkout | ||||||||||
| uses: actions/checkout@v4 | ||||||||||
| - *checkout | ||||||||||
|
|
||||||||||
| - name: CI script | ||||||||||
| env: ${{ matrix.env_vars }} | ||||||||||
|
|
@@ -362,9 +334,7 @@ jobs: | |||||||||
| dockerfile: ./ci/linux-debian.Dockerfile | ||||||||||
| tag: ${{ matrix.docker_arch }}-debian-image | ||||||||||
|
|
||||||||||
| - name: Print logs | ||||||||||
| uses: ./.github/actions/print-logs | ||||||||||
| if: ${{ !cancelled() }} | ||||||||||
| - *print-logs | ||||||||||
|
|
||||||||||
| sanitizers_debian: | ||||||||||
| name: "UBSan, ASan, LSan" | ||||||||||
|
|
@@ -396,19 +366,9 @@ jobs: | |||||||||
| SYMBOL_CHECK: 'no' | ||||||||||
|
|
||||||||||
| steps: | ||||||||||
| - name: Checkout | ||||||||||
| uses: actions/checkout@v4 | ||||||||||
|
|
||||||||||
| - name: CI script | ||||||||||
| env: ${{ matrix.configuration.env_vars }} | ||||||||||
| uses: ./.github/actions/run-in-docker-action | ||||||||||
| with: | ||||||||||
| dockerfile: ./ci/linux-debian.Dockerfile | ||||||||||
| tag: x64-debian-image | ||||||||||
|
|
||||||||||
| - name: Print logs | ||||||||||
| uses: ./.github/actions/print-logs | ||||||||||
| if: ${{ !cancelled() }} | ||||||||||
| - *checkout | ||||||||||
| - *x64_ci_script | ||||||||||
| - *print-logs | ||||||||||
|
|
||||||||||
| msan_debian: | ||||||||||
| name: "MSan" | ||||||||||
|
|
@@ -447,20 +407,9 @@ jobs: | |||||||||
| SYMBOL_CHECK: 'no' | ||||||||||
|
|
||||||||||
| steps: | ||||||||||
| - name: Checkout | ||||||||||
| uses: actions/checkout@v4 | ||||||||||
|
|
||||||||||
| - name: CI script | ||||||||||
| env: ${{ matrix.configuration.env_vars }} | ||||||||||
| uses: ./.github/actions/run-in-docker-action | ||||||||||
| with: | ||||||||||
| dockerfile: ./ci/linux-debian.Dockerfile | ||||||||||
| tag: x64-debian-image | ||||||||||
|
|
||||||||||
| - name: Print logs | ||||||||||
| uses: ./.github/actions/print-logs | ||||||||||
| if: ${{ !cancelled() }} | ||||||||||
|
|
||||||||||
| - *checkout | ||||||||||
| - *x64_ci_script | ||||||||||
| - *print-logs | ||||||||||
|
|
||||||||||
| mingw_debian: | ||||||||||
| name: ${{ matrix.configuration.job_name }} | ||||||||||
|
|
@@ -490,19 +439,9 @@ jobs: | |||||||||
| HOST: 'i686-w64-mingw32' | ||||||||||
|
|
||||||||||
| steps: | ||||||||||
| - name: Checkout | ||||||||||
| uses: actions/checkout@v4 | ||||||||||
|
|
||||||||||
| - name: CI script | ||||||||||
| env: ${{ matrix.configuration.env_vars }} | ||||||||||
| uses: ./.github/actions/run-in-docker-action | ||||||||||
| with: | ||||||||||
| dockerfile: ./ci/linux-debian.Dockerfile | ||||||||||
| tag: x64-debian-image | ||||||||||
|
|
||||||||||
| - name: Print logs | ||||||||||
| uses: ./.github/actions/print-logs | ||||||||||
| if: ${{ !cancelled() }} | ||||||||||
| - *checkout | ||||||||||
| - *x64_ci_script | ||||||||||
| - *print-logs | ||||||||||
|
|
||||||||||
| x86_64-macos-native: | ||||||||||
| name: "x86_64: macOS Ventura, Valgrind" | ||||||||||
|
|
@@ -531,8 +470,7 @@ jobs: | |||||||||
| - BUILD: 'distcheck' | ||||||||||
|
|
||||||||||
| steps: | ||||||||||
| - name: Checkout | ||||||||||
| uses: actions/checkout@v4 | ||||||||||
| - *checkout | ||||||||||
|
|
||||||||||
| - name: Install Homebrew packages | ||||||||||
| run: | | ||||||||||
|
|
@@ -552,9 +490,7 @@ jobs: | |||||||||
| python3 -m pip install lief | ||||||||||
| python3 ./tools/symbol-check.py .libs/libsecp256k1.dylib | ||||||||||
|
|
||||||||||
| - name: Print logs | ||||||||||
| uses: ./.github/actions/print-logs | ||||||||||
| if: ${{ !cancelled() }} | ||||||||||
| - *print-logs | ||||||||||
|
|
||||||||||
| arm64-macos-native: | ||||||||||
| name: "ARM64: macOS Sonoma" | ||||||||||
|
|
@@ -583,8 +519,7 @@ jobs: | |||||||||
| - BUILD: 'distcheck' | ||||||||||
|
|
||||||||||
| steps: | ||||||||||
| - name: Checkout | ||||||||||
| uses: actions/checkout@v4 | ||||||||||
| - *checkout | ||||||||||
|
|
||||||||||
| - name: Install Homebrew packages | ||||||||||
| run: | | ||||||||||
|
|
@@ -605,10 +540,7 @@ jobs: | |||||||||
| python3 -m pip install lief | ||||||||||
| python3 ./tools/symbol-check.py .libs/libsecp256k1.dylib | ||||||||||
|
|
||||||||||
| - name: Print logs | ||||||||||
| uses: ./.github/actions/print-logs | ||||||||||
| if: ${{ !cancelled() }} | ||||||||||
|
|
||||||||||
| - *print-logs | ||||||||||
|
|
||||||||||
| win64-native: | ||||||||||
| name: ${{ matrix.configuration.job_name }} | ||||||||||
|
|
@@ -635,8 +567,7 @@ jobs: | |||||||||
| cmake_options: '-T ClangCL' | ||||||||||
|
|
||||||||||
| steps: | ||||||||||
| - name: Checkout | ||||||||||
| uses: actions/checkout@v4 | ||||||||||
| - *checkout | ||||||||||
|
|
||||||||||
| - name: Generate buildsystem | ||||||||||
| run: cmake -E env CFLAGS="/WX ${{ matrix.configuration.cpp_flags }}" cmake -B build -DSECP256K1_ENABLE_MODULE_RECOVERY=ON -DSECP256K1_BUILD_EXAMPLES=ON ${{ matrix.configuration.cmake_options }} | ||||||||||
|
|
@@ -671,8 +602,7 @@ jobs: | |||||||||
| runs-on: windows-2022 | ||||||||||
|
|
||||||||||
| steps: | ||||||||||
| - name: Checkout | ||||||||||
| uses: actions/checkout@v4 | ||||||||||
| - *checkout | ||||||||||
|
|
||||||||||
| - name: Add cl.exe to PATH | ||||||||||
| uses: ilammy/msvc-dev-cmd@v1 | ||||||||||
|
|
@@ -686,6 +616,11 @@ jobs: | |||||||||
| runs-on: ubuntu-latest | ||||||||||
| needs: docker_cache | ||||||||||
|
|
||||||||||
| strategy: | ||||||||||
| matrix: | ||||||||||
| configuration: | ||||||||||
| - env_vars: {} | ||||||||||
|
|
||||||||||
|
Comment on lines
+619
to
+623
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Adding an empty matrix configuration with just 'env_vars: {}' appears to serve no functional purpose for the cpp_gcc_debian job. This adds unnecessary complexity without providing the matrix benefits that other jobs use.
Suggested change
Copilot uses AI. Check for mistakes. Positive FeedbackNegative Feedback |
||||||||||
| env: | ||||||||||
| CC: 'g++' | ||||||||||
| CFLAGS: '-fpermissive -g' | ||||||||||
|
|
@@ -699,27 +634,17 @@ jobs: | |||||||||
| ELLSWIFT: 'yes' | ||||||||||
|
|
||||||||||
| steps: | ||||||||||
| - name: Checkout | ||||||||||
| uses: actions/checkout@v4 | ||||||||||
|
|
||||||||||
| - name: CI script | ||||||||||
| uses: ./.github/actions/run-in-docker-action | ||||||||||
| with: | ||||||||||
| dockerfile: ./ci/linux-debian.Dockerfile | ||||||||||
| tag: x64-debian-image | ||||||||||
|
|
||||||||||
| - name: Print logs | ||||||||||
| uses: ./.github/actions/print-logs | ||||||||||
| if: ${{ !cancelled() }} | ||||||||||
| - *checkout | ||||||||||
| - *x64_ci_script | ||||||||||
| - *print-logs | ||||||||||
|
|
||||||||||
| cxx_headers_debian: | ||||||||||
| name: "C++ (public headers)" | ||||||||||
| runs-on: ubuntu-latest | ||||||||||
| needs: docker_cache | ||||||||||
|
|
||||||||||
| steps: | ||||||||||
| - name: Checkout | ||||||||||
| uses: actions/checkout@v4 | ||||||||||
| - *checkout | ||||||||||
|
|
||||||||||
| - name: CI script | ||||||||||
| uses: ./.github/actions/run-in-docker-action | ||||||||||
|
|
@@ -738,8 +663,7 @@ jobs: | |||||||||
| options: --user root | ||||||||||
|
|
||||||||||
| steps: | ||||||||||
| - name: Checkout | ||||||||||
| uses: actions/checkout@v4 | ||||||||||
| - *checkout | ||||||||||
|
|
||||||||||
| - name: CI script | ||||||||||
| run: | | ||||||||||
|
|
@@ -750,8 +674,7 @@ jobs: | |||||||||
| runs-on: ubuntu-latest | ||||||||||
|
|
||||||||||
| steps: | ||||||||||
| - name: Checkout | ||||||||||
| uses: actions/checkout@v4 | ||||||||||
| - *checkout | ||||||||||
|
|
||||||||||
| - run: ./autogen.sh && ./configure --enable-dev-mode && make distcheck | ||||||||||
|
|
||||||||||
|
|
||||||||||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Adding an empty matrix configuration with just 'env_vars: {}' appears to serve no functional purpose for the i686_debian job. This adds unnecessary complexity without providing the matrix benefits that other jobs use.
Copilot uses AI. Check for mistakes.