Remove deprecated secp256k1_schnorrsig_sign alias#1776
Open
theStack wants to merge 1 commit intobitcoin-core:masterfrom
Open
Remove deprecated secp256k1_schnorrsig_sign alias#1776theStack wants to merge 1 commit intobitcoin-core:masterfrom
secp256k1_schnorrsig_sign alias#1776theStack wants to merge 1 commit intobitcoin-core:masterfrom
Conversation
This function has been deprecated since the rename to `_schnorrsig_sign32` more than three and a half years ago (see PR bitcoin-core#1089, commit 99e6568), before the first official release 0.2.0. Removing it should be fine by now.
theStack
force-pushed
the
remove_deprecated_schnorrsig_sign
branch
from
2b93564 to
405e29b
Compare
real-or-random
approved these changes
Nov 27, 2025
Contributor
real-or-random
left a comment
real-or-random
left a comment
There was a problem hiding this comment.
utACK 405e29b
This change is fine, but it's not at all necessary or urgent, so we may want to postpone this until we have more reason to do a breaking release.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This function has been deprecated since the rename to
_schnorrsig_sign32more than three and a half years ago (see PR #1089, commit 99e6568), before the first official release 0.2.0. Removing it should be fine by now.