Verify non-null data arg in ellswift xdh_hash_function_prefix#1806
Open
furszy wants to merge 1 commit intobitcoin-core:masterfrom
Open
Verify non-null data arg in ellswift xdh_hash_function_prefix#1806furszy wants to merge 1 commit intobitcoin-core:masterfrom
furszy wants to merge 1 commit intobitcoin-core:masterfrom
Conversation
The secp256k1_ellswift_xdh API has a `data` arg that is optional for one of the hash functions (unused) but required for the other. This adds a simple check to provide a clear error instead of crashing due to an out-of-bounds memory access when the user mistakenly provides data=NULL and selects the `xdh_hash_function_prefix()` function.
sipa
reviewed
Jan 23, 2026
Contributor
Note that VERIFY_CHECKs are only active in the tests. |
Member
Author
We can't use Update: We probably could leave this open until the other PR gets merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
secp256k1_ellswift_xdhAPI has adataarg that is optional for oneof the hash functions (unused) but required for the other.
This adds a simple check to provide a clear error instead of crashing
due to an out-of-bounds memory access when the user mistakenly provides
data=NULL and selects the
xdh_hash_function_prefix()function.Note: Open to improving the arg description in the API as well. I'm just adding
this check because a better error would have saved me a few minutes.