-
Notifications
You must be signed in to change notification settings - Fork 1.1k
ci: add workflow to clean caches periodically #1807
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Concept ACK
I'm a bit hesitant due to the actions: write permission, but I tend to think it's okay here. This workflow doesn't even have an input that could be attacker controlled. And actions restricts it to GitHub Actions stuff.
fcb90a0 to
a27ae1a
Compare
real-or-random
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK a27ae1a
|
cc @hebasto |
hebasto
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's shame that https://github.com/actions/cache does not provide an option to set a retention period explicitly.
I think we could avoid introducing a new workflow with the write permission by simply rotating the cache keys regularly. Feel free to grab a commit from this branch.
That seems cleaner indeed. edit: This means for this PR: Approach NACK |
|
Unrelated to the changes in this PR, the current GCC snapshot has been failing self-tests since ed2924c7628343ff8b699f320a05c85bdb9c2837. UPDATE: The issue should be fixed in a6c3c48148dd60a09ffab57019f163180c159d65. |
Deletes all caches on the 1st and 15th of each month.
Fixes #1691