Skip to content

Conversation

@8144225309
Copy link

@8144225309 8144225309 commented Jan 25, 2026

Deletes all caches on the 1st and 15th of each month.

Fixes #1691

Copy link
Contributor

@real-or-random real-or-random left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Concept ACK

I'm a bit hesitant due to the actions: write permission, but I tend to think it's okay here. This workflow doesn't even have an input that could be attacker controlled. And actions restricts it to GitHub Actions stuff.

Copy link
Contributor

@real-or-random real-or-random left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK a27ae1a

@real-or-random
Copy link
Contributor

cc @hebasto

Copy link
Member

@hebasto hebasto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's shame that https://github.com/actions/cache does not provide an option to set a retention period explicitly.

I think we could avoid introducing a new workflow with the write permission by simply rotating the cache keys regularly. Feel free to grab a commit from this branch.

@real-or-random
Copy link
Contributor

real-or-random commented Jan 27, 2026

I think we could avoid introducing a new workflow with the write permission by simply rotating the cache keys regularly.

That seems cleaner indeed.


edit: This means for this PR:

Approach NACK

@hebasto
Copy link
Member

hebasto commented Jan 27, 2026

Unrelated to the changes in this PR, the current GCC snapshot has been failing self-tests since ed2924c7628343ff8b699f320a05c85bdb9c2837.

UPDATE: The issue should be fixed in a6c3c48148dd60a09ffab57019f163180c159d65.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ci: Clean the cache regularly to test on new compiler snapshots

3 participants