bench: Update help functions in bench and bench_internal #1811
+9
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the bench and bench_internal help functions argv was not being passed, in this change we pass in argv and use it in the help text.
| #include "bench.h" | ||
|
|
||
| static void help(int default_iters) { | ||
| static void help(char **argv, int default_iters) { |
Contributor
There was a problem hiding this comment.
nit: I know this uses only argv[0], but still, this interface seems a bit cursed because you can't really use argv without argc. Either you pass both argc and argv (like in have_flag), or you simply only argv[0].
real-or-random
added
tweak/refactor
user-documentation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This change is motivated by #1793 (review)
Description
In the
benchandbench_internalhelpfunctionsargvwas not being passed. In this change, we pass in argv and use it in the help text.