Remove trailing spaces and introduce -Wtrailing-whitespace=any compiler flag
#1813
Conversation
hebasto
force-pushed
the
260128-trailing-space
branch
2 times, most recently
from
60c3420 to
65f0e7f
Compare
real-or-random
left a comment
real-or-random
left a comment
There was a problem hiding this comment.
Concept ACK...
I was a bit surprised to see that GCC has this option given that it's not primarily a linter, but okay, happy to take them if they're for free.
I think if we enable this, we could as well enable -Wleading-whitespace=spaces?
real-or-random
added
tweak/refactor
meta/development
hebasto
force-pushed
the
260128-trailing-space
branch
from
65f0e7f to
d9c3235
Compare
|
Thank you for the review! Your feedback has been addressed.
Done. |
real-or-random
left a comment
real-or-random
left a comment
There was a problem hiding this comment.
utACK d9c3235
The CI failures on QEMU jobs are certainly unrelated, but let's maybe wait for the non-QEMU jobs.
Hmm... The failed runs are reusing old Docker images, so there shouldn't be any changes in that environment. |
|
I agree that this is very dubious. I've just triggered a rerun of all jobs. Let's see if this solves it. And if not, we can still check if the same jobs fail as in the first run. Clearing the cache may also be some other shot in the dark, but let's wait for now. |
They differ... |
|
|
This could very well be the reason. Let's just wait for a day to let this settle a bit. (I'm, in principle, happy to merge this PR as-is, but then CI may end up being red on master, which I would like to avoid.) |
FWIW, I've triggered a cache invalidation in hebasto@94ec4e2, and the resulting CI run is 100% green. |
2 participants
This PR removes trailing whitespace and introduces the
-Wtrailing-whitespace=anycompiler flag. This enforces the rule from CONTRIBUTING.md ("Avoid trailing whitespace") directly in the CI.This fix is required to unbreak Bitcoin Core CI builds using GCC 15 after merging bitcoin/bitcoin#34412.