Skip to content

Conversation

@willcl-ark
Copy link
Contributor

Hopefully this will fix the ruff inconsistencies between local and CI envs.

Install the correct version using uv:

# install
$ uv tool install [email protected]

# use
$ uvx [email protected] check .

If this is the only version you have installed then it may be possible to still use the shorthand, if the version comes back correct:

$ uvx ruff --version
ruff 0.6.8

$ uvx ruff check.

@willcl-ark willcl-ark force-pushed the pin-ruff branch 5 times, most recently from cb28e96 to 293da96 Compare October 3, 2024 15:06
@pinheadmz
Copy link
Contributor

--> uv tool install [email protected]
error: Failed to parse: `[email protected]`
  Caused by: Expected path (`/Users/matthewzipkin/0.6.8`) to end in a supported file extension: `.whl`, `.zip`, `.tar.gz`, `.tar.bz2`, `.tar.xz`, or `.tar.zst`
[email protected]
     ^^^^^

@pinheadmz
Copy link
Contributor

I do like this:

(.venv) --> uvx ruff check .
ruff failed
  Cause: Required version `==0.6.8` does not match the running version `0.6.9`

@pinheadmz
Copy link
Contributor

ok the command that worked for me was uvx install tool 'ruff==0.6.8'

Copy link
Contributor

@pinheadmz pinheadmz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Id suggest adding to the docs somewhere how to install the right version, then lets merge this!

@bdp-DrahtBot
Copy link
Collaborator

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Conflicts

Reviewers, this pull request conflicts with the following ones:

  • #616 (Using team namespaces: Kubeconfig Step Thru by mplsgrant)

If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

@willcl-ark
Copy link
Contributor Author

Id suggest adding to the docs somewhere how to install the right version, then lets merge this!

Done

@pinheadmz pinheadmz merged commit 7b4dd1e into bitcoin-dev-project:main Oct 7, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants