scenarios: miner_std should accept single --tank option #627
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pinheadmz
force-pushed
the
miner-std-single
branch
from
a12bf46 to
ff4b8d7
Compare
Collaborator
|
uTACK |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently miner_std either tries to mine from ALL nodes or only the 0th node in the network. Since it also naively calls rpc
createwalletand some older node versions do not support that command, the scenario fails. I think we can also modify the scenario to be more flexible with older versions but it also makes sense to be able to just pick a single mining node. The signet miner scenario already has this option.