Skip to content

Conversation

@mplsgrant
Copy link
Collaborator

@mplsgrant mplsgrant commented Oct 10, 2024

Within the auth function, check for and create (if needed) a folder appropriate to the KUBECONFIG path.

Addresses #642

I didn't like the way I originally checked for the directory, then created it -- all the while using
hard-coded values. This one-liner will attempt to make the directory based on KUBECONFIG and if it
exists, then it won't complain. However, if it does not exist, it will create it. This also should
solve the case of the user having a bespoke KUBECONFIG directory in which they deleted their
"config" file. Now, we will use their bespoke path and create the config file in their preferred location.
@mplsgrant mplsgrant requested a review from pinheadmz October 10, 2024 03:31
@mplsgrant mplsgrant mentioned this pull request Oct 10, 2024
Copy link
Contributor

@pinheadmz pinheadmz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested ACK thank you

@pinheadmz pinheadmz merged commit cccf11b into bitcoin-dev-project:main Oct 10, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants