log correct number of outbound connections #671
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pinheadmz
approved these changes
Dec 6, 2024
Contributor
pinheadmz
left a comment
pinheadmz
left a comment
There was a problem hiding this comment.
tested ACK
THANK YOU Charmaine! Great catch here. I will merge to main and also build and push the revised bitcoin-exporter image to docker hub. You may need to remove your local copy of the image to force docker to pull the update.
Example dashboard using 12 node below. You can see how long it takes for all nodes to connect!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently,
connections_inis used for both inbound and outbound peers. The PR corrects this by usingconnections_outfor outbound peers.