let python3 run plugin.py instead of bash
#689
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
pinheadmz
reviewed
Mar 7, 2025
src/warnet/deploy.py
Outdated
|
|
||
| cmd = ( | ||
| f"{network_file_path.parent / entrypoint_path / Path('plugin.py')} entrypoint " | ||
| f"python3 {network_file_path.parent / entrypoint_path / Path('plugin.py')} entrypoint " |
Contributor
There was a problem hiding this comment.
there's a trick to this, see how bitcoin test runner calls python from inside python:
`python3` seems to be the right way to call python from both linux and macos.
mplsgrant
force-pushed
the
2025-03-let-python-do-it
branch
from
7b3cf4c to
6f642e3
Compare
Contributor
|
LGTM, merge when you're happy |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
plugin.pyshould just be ingested by python instead doing what we do today which is chmod-ingplugin.pyand calling it via bash.Also, when deciding between using
pythonandpython3, I did some research andpython3is allegedly the sure-fire way to call python on both linux and macos.Addresses #678