Skip to content

Tidy up build command #703

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 1, 2025
Merged

Tidy up build command #703

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
44c3c1b
remove unused docker_registry param
willcl-ark Mar 31, 2025
ff34691
TypeError: build() missing 1 required positional argument: 'registry'
pinheadmz Mar 31, 2025
7af515b
add example to build image docs
pinheadmz Mar 31, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 10 additions & 6 deletions src/warnet/image.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,6 @@ def image():
@image.command()
@click.option("--repo", required=True, type=str)
@click.option("--commit-sha", required=True, type=str)
@click.option("--registry", required=True, type=str)
@click.option(
"--tags",
required=True,
Expand All @@ -23,11 +22,16 @@ def image():
@click.option("--build-args", required=False, type=str)
@click.option("--arches", required=False, type=str)
@click.option("--action", required=False, type=str, default="load")
def build(repo, commit_sha, registry, tags, build_args, arches, action):
"""
Build bitcoind and bitcoin-cli from <repo> at <commit_sha> with the specified <tags>.
Optionally deploy to remote registry using --action=push, otherwise image is loaded to local registry.
def build(repo, commit_sha, tags, build_args, arches, action):
"""Build a Bitcoin Core Docker image with specified parameters.

\b
Usage Examples:
# Build an image for Warnet repository
warnet image build --repo bitcoin/bitcoin --commit-sha d6db87165c6dc2123a759c79ec236ea1ed90c0e3 --tags bitcoindevproject/bitcoin:v29.0-rc2 --arches amd64,arm64,armhf --action push
# Build an image for local testing
warnet image build --repo bitcoin/bitcoin --commit-sha d6db87165c6dc2123a759c79ec236ea1ed90c0e3 --tags bitcoindevproject/bitcoin:v29.0-rc2 --action load
"""
res = build_image(repo, commit_sha, registry, tags, build_args, arches, action)
res = build_image(repo, commit_sha, tags, build_args, arches, action)
if not res:
sys.exit(1)
2 changes: 0 additions & 2 deletions src/warnet/image_build.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,6 @@ def run_command(command):
def build_image(
repo: str,
commit_sha: str,
docker_registry: str,
tags: str,
build_args: str,
arches: str,
Expand All @@ -41,7 +40,6 @@ def build_image(

print(f"{repo=:}")
print(f"{commit_sha=:}")
print(f"{docker_registry=:}")
print(f"{tags=:}")
print(f"{build_args=:}")
print(f"{build_arches=:}")
Expand Down
Loading