-
Notifications
You must be signed in to change notification settings - Fork 55
Add eclair support #2 #724
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
macgyver13
wants to merge
15
commits into
bitcoin-dev-project:main
Choose a base branch
from
macgyver13:add-eclair
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 1 commit
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
234137e
Add eclair support to simln plugin - upgrade to 0.2.4
macgyver13 06e4366
fix format
macgyver13 3238e64
fix fee rate calculation assumptions for eclair channels
macgyver13 d56b880
Merge branch 'main' into add-eclair
macgyver13 efb2deb
correct lnd node syntax graph::import-network
macgyver13 d509de0
remove fixme
macgyver13 4aadc52
fix logging test - enable lnd to satisfy metric
macgyver13 8291e7e
reverse capture_output change
macgyver13 4a109cf
add support for testing LNNode through rpc
macgyver13 f232768
fix eclair channelbalance calculation issue
macgyver13 fdbaf71
make cln rune creation more robust with startupProbe
macgyver13 c99f8fd
increase delay on eclair channel open retries
macgyver13 4d12d87
address eclair stability with dnsseed bitcoin core config
macgyver13 d49ac95
ensure channel announcement gossip try forever
macgyver13 fcc3ba5
improve eclair gossip stability
macgyver13 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lets take this out, it may have a broader impact on bitcoin p2p in warnet and i just don't see how it could possibly affect eclair
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
want to conditionally add dnsseed property for bitcoincore nodes attached to eclair or just remove all together?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove altogether - I can't see how eclair needs this