Skip to content

Add eclair support #2 #724

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 15 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions resources/charts/bitcoincore/charts/eclair/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -6,9 +6,9 @@ namespace: warnet
restartPolicy: Never

image:
repository: bitdonkey/eclair
repository: polarlightning/eclair
pullPolicy: IfNotPresent
tag: "0.11.0"
tag: "0.12.0"

imagePullSecrets: []
nameOverride: ""
Expand Down
1 change: 1 addition & 0 deletions resources/charts/bitcoincore/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -129,6 +129,7 @@ baseConfig: |
rpcallowip=0.0.0.0/0
rpcbind=0.0.0.0
rest=1
dnsseed=0 # needed for eclair stability
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lets take this out, it may have a broader impact on bitcoin p2p in warnet and i just don't see how it could possibly affect eclair

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

want to conditionally add dnsseed property for bitcoincore nodes attached to eclair or just remove all together?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove altogether - I can't see how eclair needs this

# rpcport and zmq endpoints are configured by chain in configmap.yaml

config: ""
Expand Down
Loading