-
Notifications
You must be signed in to change notification settings - Fork 55
Prepare LN for large networks #737
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
pinheadmz
wants to merge
11
commits into
bitcoin-dev-project:main
Choose a base branch
from
pinheadmz:ln-neverfail
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
ea66a0b
ln: remove all retry logic so errors propogate up
pinheadmz 4f79eca
ln_init: never fail
pinheadmz b7a54c7
test: remove unused scenario run from ln_basic
pinheadmz 1943068
fix 50 node LN JSON file name
pinheadmz 6de4b72
test data: add LN_100
pinheadmz 46395d7
ln: move constants to common file and refactor miner funds distro
pinheadmz 0f442d2
ln_init: various bug fixes for large networks
pinheadmz 1085974
test: fix tests after ln_init changes
pinheadmz 08cb3e4
lint
pinheadmz d8f7259
lnd createinvoice: drop description
pinheadmz 216191b
deploy: check ln nodes if prometheus and grafana are needed
pinheadmz File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Large diffs are not rendered by default.
Oops, something went wrong.
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -204,6 +204,8 @@ def check_logging_required(directory: Path): | |
return True | ||
if default_file.get("metricsExport", False): | ||
return True | ||
if default_file.get("lnd", False).get("metricsExport"): | ||
return True | ||
|
||
# check to see if individual nodes have logging enabled | ||
network_file_path = directory / NETWORK_FILE | ||
|
@@ -216,6 +218,8 @@ def check_logging_required(directory: Path): | |
return True | ||
if node.get("metricsExport", False): | ||
return True | ||
if node.get("lnd", False).get("metricsExport"): | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. ^^ same problem |
||
return True | ||
|
||
return False | ||
|
||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you need to use {} for the default value
if default_file.get("lnd", {}).get("metricsExport"):