Add mobile sidebar animation and prevent layout shift #4510
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add slide and fade transitions to mobile sidebar - Change mob-sidebar-open button to fade in/out instead of display:none - Keep button in DOM flow when hidden to prevent layout shift
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The mobile sidebar on the FAQ and other pages instantly appears and disappears when toggled and it feels jarring to have the layout jump so quickly. Also when the
mob-sidebar-openbutton isn't fixed, hiding and revealing it causes a noticeable layout shift for the content underneath it.This modification will:
mob-sidebar-openbutton in DOM flow when hidden to prevent layout shiftThe layout and structure should appear identical to the original (minus the layout shift).
Before & After Demo
bitcoinsidebar.webm