Add Bitcoin Knots as a node software #4541
Conversation
|
Approved, not that it means anything. However, I did review the changes, don't see any issues, think this is a fair idea. |
Psifour
left a comment
Psifour
left a comment
There was a problem hiding this comment.
Concept NACK
This is an underdeveloped inclusion that requires significant work to get it to the level expected of bitcoin-dot-org. Specifically, inclusion of forks of Core is something I could potentially support, but this makes future development of a 'forks' page to link to them harder by creating technical debt.
The content of the PR (copy, etc) is almost at a passable level, but it completely disregards the immense work that has been put into bitcoin.org to make the sites localization world-class, fails to follow the existing standards, and has arguably worse UX as a result.
| {% endcomment %} | ||
|
|
||
| <div class="callout"> | ||
| <a class="callout-btn btn-bright" href="https://bitcoinknots.org/files/29.x/29.1.knots20250903/">Download Bitcoin Knots</a> |
| {% endcomment %} | ||
|
|
||
| <div class="callout"> | ||
| <a class="callout-btn btn-bright" href="https://bitcoinknots.org/files/29.x/29.1.knots20250903/">Download Bitcoin Knots</a> |
There was a problem hiding this comment.
Even if linking offsite the language settings/localization should be preserved to avoid making the UX worse.
| <a class="callout-btn btn-bright" href="https://bitcoinknots.org/files/29.x/29.1.knots20250903/">Download Bitcoin Knots</a> | ||
| <div class="row callout-row"> | ||
| <span class="btn-subtext">Bitcoin Knots 29.1</span> |
There was a problem hiding this comment.
Version numbers should be exposed for adjustment like we see in the equivalent page for Core. Static text appears to be undesirable if you observe the existing work.
| http://opensource.org/licenses/MIT. | ||
| {% endcomment %} | ||
|
|
||
| <a class="logo" href="/en/bitcoin-knots/"><img src="/img/bitcoin-knots/knots-logo-short-black-orange-1024.svg?{{site.time | date: '%s'}}" alt="Bitcoin"></a> |
There was a problem hiding this comment.
Provided logo image does not match existing Core logo aspect-ratio. Any layout validation that was conducted previously should be repeated to verify this doesn't meaningfully impact UI/UX.
| {% else %} | ||
| <li{% if page.id == 'download' %} class="active"{% endif %}><a href="/{{page.lang}}/{% translate download url %}">{% translate bitcoin-core layout %}</a></li> | ||
| {% endif %} | ||
| <li><a href="/en/bitcoin-knots/">Bitcoin Knots</a></li> |
There was a problem hiding this comment.
Should be included in the localization as a string for later translation (see L54)
| {% else %} | ||
| <li{% if page.id == 'download' %} class="active"{% endif %}><a href="/{{page.lang}}/{% translate download url %}">{% translate bitcoin-core layout %}</a></li> | ||
| {% endif %} | ||
| <li><a href="/en/bitcoin-knots/">Bitcoin Knots</a></li> |
There was a problem hiding this comment.
Does not follow style of all previous elements in this menu (doesn't set the 'active' class when it is the currently selected page). Instead it appears the bitcoin-core menu option would have active set?
| the topic (which is usually automatically displayed) to learn the rules | ||
| for that chatroom. | ||
|
|
||
| - [#OCEAN][] hosts discussion about Bitcoin mining, including |
There was a problem hiding this comment.
Paired suggestion with the one in references.md
| - [#OCEAN][] hosts discussion about Bitcoin mining, including | |
| - [#OCEAN][ocean irc] hosts discussion about Bitcoin mining, including |
| <div class="show_more-list" markdown="block"> | ||
|
|
||
| * <span>Better security for their bitcoins</span> | ||
| * <span>Privacy featuresnot available in other wallets</span> |
There was a problem hiding this comment.
| * <span>Privacy featuresnot available in other wallets</span> | |
| * <span>Privacy features not available in other wallets</span> |
| Bitcoin Knots is programmed to decide which block chain contains | ||
| valid transactions and give extended control over your node. |
There was a problem hiding this comment.
Adjusting the copy here to better highlight the focus on user configuration is likely better in terms of convincing users to switch to this fork. Most users will not make it past the first few sentences of documentation so leading with your strongest foot is always a good idea.
| [native irc client]: https://en.wikipedia.org/wiki/List_of_IRC_clients | ||
| [netcat]: https://en.wikipedia.org/wiki/Netcat | ||
| [nop opcodes]: https://en.bitcoin.it/wiki/Script#Reserved_words | ||
| [#OCEAN]: https://webchat.freenode.net/?channels=OCEAN&uio=d4 |
There was a problem hiding this comment.
Always try to use the style present in a file when making inclusions. Pairs with the change on help.md
| [#OCEAN]: https://webchat.freenode.net/?channels=OCEAN&uio=d4 | |
| [ocean irc]: https://webchat.freenode.net/?channels=OCEAN&uio=d4 |
|
I will consider putting more effort into this depending on if @Cobra-Bitcoin wants to merge such PR. |
|
Concept ACK With 20% of the network using knots, it is worth adding on https://bitcoin.org an an alternative client. |
|
I tried to have Knots more prominently featured on bitcoin.org many years ago so I have some history with this topic. I'm curious what the wallets maintainer @crwatkins thinks about this and also former contributor @harding who created a lot of bitcoin.org's promotional material for Bitcoin Core. Bitcoin.org is perceived as Bitcoin's "official" site and the battle between Core and Knots seems intense right now. I'm concerned about sweeping changes to the content of the site being made to score political wins and not necessarily for the benefit of the users. This PR seems rushed and quickly thrown together, there is no justification for why these changes are being made, and saying you will only put more effort into this if you get confirmation it'll be merged doesn't sit well with me. The timing on this is terrible. If we merge something like this it would give the impression bitcoin.org is very pro Knots (or at least trending in that direction). We don't even have an official response to the v30 controversy because we've been so badly burned in the past by Bitcoin politics so you can imagine PRs like this give me nightmares. |
|
This pull request does not remove bitcoin core from the website. It adds an alternative. |
I feel the download and marketing pages for Bitcoin Core on Bitcoin.org are a historical artifact, due to the GitHub repo for this site being under Bitcoin Core control over a decade ago, rather than an actively maintained site feature. New releases and new project information for Bitcoin Core has been posted to BitcoinCore.org since 2016 (initially in addition to posting to Bitcoin.org, but later most Bitcoin Core project material material was exclusively posted to BitcoinCore.org). I think it makes the most sense for every project to have its own independent site. Bitcoin.org can then link to those projects as its maintainers see fit, e.g. a page for full nodes can link to multiple implementations based on various criteria. This would give btcd, libbitcoin, librerelay, and other projects an equal shot at being listed alongside Core and Knots. If it's perceived as excessively unfair that Bitcoin.org hosts Bitcoin Core material, then I would advocate removing that material rather than encouraging every node implementation to have separate pages on the site. |
|
I agree with @harding too. |
|
@Cobra-Bitcoin When do you think the right moment to merge this PR will be? |
PR is incomplete in its current form (see my review above) and represents a solution that doesn't seem to align with the expectations of both current/former contributors (see above comments by Cobra, harding, and crwatkins). |
8 participants
No description provided.