Skip to content

BIP 360 - Pay to Tapscript Hash (P2TSH) #1670

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
cryptoquick wants to merge 133 commits into
base: master
Choose a base branch
from
+9,242 −0
Open

BIP 360 - Pay to Tapscript Hash (P2TSH) #1670

Show file tree
Hide file tree
Changes from 48 commits
Commits
Show all changes
133 commits
Select commit Hold shift + click to select a range
1fa2485
QuBit - P2QRH spending rules - Final draft before submitting upstream…
cryptoquick Sep 27, 2024
6f67a3d
Add pqNTRUsign to .typos.toml.
cryptoquick Sep 27, 2024
d83c29d
QuBit - P2QRH
cryptoquick Sep 28, 2024
ae0936a
typo fix
jlopp Oct 2, 2024
d89b7c5
Merge pull request #13 from jlopp/patch-3
cryptoquick Oct 4, 2024
b4c329b
QuBit - P2QRH spending rules
cryptoquick Oct 21, 2024
53d497e
Adds clarity and brevity
Nov 5, 2024
0a2ed4a
Apply suggestions from review
cryptoquick Nov 21, 2024
c92a9b0
QuBit - P2QRH spending rules
cryptoquick Nov 21, 2024
e1b7007
Add details on attestation structure and parsing. (#14)
cryptoquick Dec 3, 2024
60d7294
MediaWiki formatting fixes
cryptoquick Dec 3, 2024
2d098d9
MediaWiki formatting fixes
cryptoquick Dec 5, 2024
ed4e862
MediaWiki fixes, remove redundant sections. (#16)
cryptoquick Dec 6, 2024
f2426c6
Update title and formatting.
cryptoquick Dec 6, 2024
2e4ad81
More wrestling with MediaWiki formatting...
cryptoquick Dec 6, 2024
9935005
I give up. Removing code and pre blocks.
cryptoquick Dec 6, 2024
cc47f9e
More formatting fixes.
cryptoquick Dec 6, 2024
ff4d2c2
Apply suggestions from code review
cryptoquick Dec 6, 2024
f206b97
Address Murch feedback.
cryptoquick Dec 6, 2024
70649ea
Merge branch 'p2qrh' of github.com:cryptoquick/bips into p2qrh
cryptoquick Dec 6, 2024
feff847
MediaWiki formatting.
cryptoquick Dec 6, 2024
e186b52
Swap layer and title.
cryptoquick Dec 9, 2024
d500124
Apply suggestions from code review
cryptoquick Dec 13, 2024
85a347b
Update to use merkle tree for attestation commitment. Update LR & SR …
cryptoquick Dec 13, 2024
85348c0
P2QRH assigned BIP number 360.
cryptoquick Dec 18, 2024
a4f3dc6
Apply suggestions from code review
cryptoquick Dec 20, 2024
2b641b8
Address feedback from vostrnad.
cryptoquick Dec 20, 2024
4b8b647
Update typos list.
cryptoquick Dec 20, 2024
990d8a8
Fixes, typos, formatting.
cryptoquick Dec 20, 2024
0fdd8c3
Updates based on Murch and vostrnad feedback.
cryptoquick Dec 20, 2024
208a987
Fix title change in README.
cryptoquick Dec 20, 2024
8eb35c8
Apply suggestions from code review
cryptoquick Dec 23, 2024
d9bb0ff
Fix broken link.
cryptoquick Dec 23, 2024
0ae69db
Remove Canary section.
cryptoquick Dec 23, 2024
81e1838
Apply suggestions from code review
cryptoquick Jan 14, 2025
c1b9047
Address suggestions from jonatack's review.
cryptoquick Jan 14, 2025
b75003e
Remove SQIsign from consideration due to significant performance conc…
cryptoquick Jan 20, 2025
5e568e3
Fix typo.
cryptoquick Jan 23, 2025
8c0f798
Fix typo.
cryptoquick Jan 23, 2025
32c0a3d
Updates based on Antoine Riard's feedback and others.
cryptoquick Feb 23, 2025
913cf79
Apply suggestions from jonasnick code review
cryptoquick Feb 24, 2025
5a1459b
Updates based on Jonas Nick's feedback.
cryptoquick Feb 24, 2025
6f3748e
Merge branch 'master' into p2qrh to fix BIP-119 linter issue
cryptoquick Mar 13, 2025
48eaf8f
Updates - 2025/03/12 (#19)
cryptoquick Mar 13, 2025
61faee6
Correct inconsistencies in commitment and attestation structure. Swit…
cryptoquick Mar 18, 2025
e6e7207
Update descriptor format.
cryptoquick Mar 18, 2025
c43487d
bip-0360: test vectors
jbride Jun 4, 2025
dc044da
p2qrh; fixes:
jbride Jun 16, 2025
3751cb2
p2qrh: enabling serde and rand features of bitcoin crate
jbride Jun 19, 2025
458d2e6
p2qrh: change name of test to reflect current focus on construction o…
jbride Jun 19, 2025
e4aae53
p2qrh: initial draft of p2qrh spend related test vectors
jbride Jun 19, 2025
f139a5f
p2qrh: rust-bitcoin modification overview
jbride Jun 20, 2025
f7d2931
p2qrh: moving location of test vector data
jbride Jun 20, 2025
a6c6449
p2qrh: separating rust from python test vectors
jbride Jun 21, 2025
fb89286
p2qrh: fixed documentation error in docs/rust_bitcoin_p2pqrh_changes.md
jbride Jun 21, 2025
b37d1d3
p2qrh: adding asm representation and description to test-vector leaf …
jbride Jun 24, 2025
3f32617
p2qrh test vectors: simple lightning contract
jbride Jun 25, 2025
2cbe246
p2qrh test vectors: specify Bitcoin network for generating p2qrh add…
jbride Jun 25, 2025
7438d08
p2qrh-testvectors: first draft of performance testing & failure analysis
jbride Jun 30, 2025
0793e2d
p2qrh: github action fix
jbride Jun 30, 2025
25a0f56
p2qrh: updates stack_element_size_performance_tests.adoc based on
jbride Jul 2, 2025
a7419a1
Remove dashes in BIP numbers and change to SegWit version 2
dplusplus1024 Jul 3, 2025
4ed8dcb
Removed more dashes and continued changes for moving version to 2
dplusplus1024 Jul 3, 2025
32cf0bd
p2qrh: pure p2tr script path spend test vector
jbride Jul 4, 2025
a375b65
Changes BIP-360 to use tapscript (#21)
EthanHeilman Jul 7, 2025
77dbeee
Update changelog and acknowledgements with the new developments in BI…
cryptoquick Jul 7, 2025
99dc227
p2qrh: removing experimental tests pertaining to descriptors
jbride Jul 7, 2025
2412aa3
p2qrh: modified spend test to reflect p2qrh specification requirement…
jbride Jul 7, 2025
107fb97
Changes BIP-360 to use tapscript (#21)
EthanHeilman Jul 7, 2025
4c5e836
Update changelog and acknowledgements with the new developments in BI…
cryptoquick Jul 7, 2025
f0123ea
Small typo fix to p2qrh related documentation.
jbride Jul 8, 2025
c10cd6c
p2qrh: add test vector and reference code to bip0360
jbride Jul 8, 2025
ac8e24f
p2qrh: spend functionality moved out of test and into a library for r…
jbride Jul 9, 2025
fa7bdad
p2qrh: first draft of end-to-end p2qrh spend scenario
jbride Jul 9, 2025
3ab1e3e
p2qrh: first successfull fund, spend and mine in bitcoin core.
jbride Jul 11, 2025
1b3f3de
P2QRH:
jbride Jul 12, 2025
63b41c3
p2qrh: p2qrh construction related test vectors now account for "Quant…
jbride Jul 12, 2025
478ebf1
p2qrh: remove reference to merkle root and replace with quantum_root
jbride Jul 13, 2025
8903528
pqrh: small modification to docs
jbride Jul 14, 2025
44778df
Fix duplicate acknowledgement
EthanHeilman Jul 15, 2025
06c2103
p2qrh: working on multi-leaf taptree example in rust for
jbride Jul 14, 2025
11f2936
p2qrh: new "common" directory to share test vector artifacts between…
jbride Jul 17, 2025
a1ef895
p2qrh: multi-leaf p2tr example now works
jbride Jul 17, 2025
1c2fb22
Fix itemize by using mediawiki splat
EthanHeilman Jul 17, 2025
5ef52b6
p2qrh: multi-leaf p2qrh example now works
jbride Jul 17, 2025
01e9d06
Use consistent naming for script path spend and key path spend.
EthanHeilman Jul 18, 2025
26113f1
Hyphenate 32-byte
EthanHeilman Jul 18, 2025
eddf8f9
Use leaf rather than tapleaf when describing leaf tapscripts in the t…
EthanHeilman Jul 18, 2025
1f65b67
Minor terminology fixes
EthanHeilman Jul 18, 2025
e3e64a6
Minor terminology fixes
EthanHeilman Jul 18, 2025
c3bd091
Remove qubit name
EthanHeilman Jul 18, 2025
1668064
Merge branch 'p2qrh' into patch-6
dplusplus1024 Jul 20, 2025
7306021
More fun with dashes
dplusplus1024 Jul 20, 2025
c4b81ea
Merge pull request #23 from dplusplus1024/patch-6
EthanHeilman Jul 21, 2025
eb3c3d3
Add ack + change log
EthanHeilman Jul 21, 2025
9a6e068
Fix label ordering
EthanHeilman Jul 21, 2025
7ab0d68
Correct Bitcoin capitalization
EthanHeilman Jul 21, 2025
13a8dc2
Consistent Taproot caps
EthanHeilman Jul 21, 2025
d8b3f7c
p2qrh: bitcoin core build instructions in end-to-end docs
jbride Jul 21, 2025
4095d33
Add example P2QRH address
EthanHeilman Jul 21, 2025
66aa330
bip-0360: test vectors
jbride Jun 4, 2025
c16554c
p2qrh; fixes:
jbride Jun 16, 2025
49fa15c
p2qrh: enabling serde and rand features of bitcoin crate
jbride Jun 19, 2025
a662e97
p2qrh: change name of test to reflect current focus on construction o…
jbride Jun 19, 2025
35c0229
p2qrh: initial draft of p2qrh spend related test vectors
jbride Jun 19, 2025
0e0feb0
p2qrh: rust-bitcoin modification overview
jbride Jun 20, 2025
0751f95
p2qrh: moving location of test vector data
jbride Jun 20, 2025
026d73c
p2qrh: separating rust from python test vectors
jbride Jun 21, 2025
9877a85
p2qrh: fixed documentation error in docs/rust_bitcoin_p2pqrh_changes.md
jbride Jun 21, 2025
794ca6f
p2qrh: adding asm representation and description to test-vector leaf …
jbride Jun 24, 2025
4658012
p2qrh test vectors: simple lightning contract
jbride Jun 25, 2025
773434b
p2qrh test vectors: specify Bitcoin network for generating p2qrh add…
jbride Jun 25, 2025
26ab582
p2qrh-testvectors: first draft of performance testing & failure analysis
jbride Jun 30, 2025
86ad55f
p2qrh: github action fix
jbride Jun 30, 2025
27f35be
p2qrh: updates stack_element_size_performance_tests.adoc based on
jbride Jul 2, 2025
5deb96f
p2qrh: pure p2tr script path spend test vector
jbride Jul 4, 2025
46c91d3
p2qrh: removing experimental tests pertaining to descriptors
jbride Jul 7, 2025
8d4d553
p2qrh: modified spend test to reflect p2qrh specification requirement…
jbride Jul 7, 2025
5a5d260
p2qrh: rust related test vectors and examples.
jbride Jul 8, 2025
bdcbb30
added org document for bip360
notmike-5 Aug 11, 2025
3da571d
revert to jbride changelist
notmike-5 Aug 13, 2025
c9aa764
Update BIP 360 entry in README
cryptoquick Dec 1, 2025
599a5f8
CI fixes
cryptoquick Dec 1, 2025
63c94ab
CI fixes - field order
cryptoquick Dec 1, 2025
c65a96a
Fix jbride typo
cryptoquick Dec 1, 2025
4c7a81e
Fix accidental status change of other entries.
cryptoquick Dec 5, 2025
56be885
BIP 360 P2TSH rewrite and general copyediting (#38)
cryptoquick Dec 19, 2025
532acfb
P2tsh pqc merge (#39)
jbride Jan 7, 2026
36fc007
Address review comments on links, wording and emdashes
EthanHeilman Jan 16, 2026
7ee326b
Address reviews, clarify wording and terminology
EthanHeilman Jan 21, 2026
6743610
Fix bug in verification, minor review comments and adopt [[bip-0003.m…
EthanHeilman Jan 23, 2026
21a2fe5
Merge branch 'master' into p2qrh
EthanHeilman Jan 23, 2026
c7b11d7
Fix header order
EthanHeilman Jan 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .typos.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,8 @@ extend-ignore-re = [
"ser.*",
"prefix.*",
"value: .*",
"pqNTRUsign",
"Strnad",
]

[default.extend-words]
Expand Down
7 changes: 7 additions & 0 deletions README.mediawiki
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1169,6 +1169,13 @@ Those proposing changes should consider that ultimately consent may rest with th
| Matt Corallo, Bastien Teinturier
| Standard
Copy link
Contributor

@murchandamus murchandamus Jan 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since the BIP 3 deployment updated all existing BIPs and the table in the README, there is now a merge conflict here. It would probably be the easiest to rebase this PR on the latest master branch.

Copy link
Contributor

@EthanHeilman EthanHeilman Jan 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ended up doing a merge, rebase kept breaking vscode for some reason.

| Draft
|-
| [[bip-0360.mediawiki|360]]
| Consensus (soft fork)
| Pay to Quantum Resistant Hash
| Hunter Beast, Ethan Heilman
| Standard
Copy link
Contributor

@murchandamus murchandamus Jan 21, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
| Standard
| Specification

Copy link
Contributor

@EthanHeilman EthanHeilman Jan 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in 6743610

| Draft
|- style="background-color: #cfffcf"
| [[bip-0370.mediawiki|370]]
| Applications
Expand Down
Loading