Skip to content

script, ci: add scripted diff checks #1900

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from
Draft

script, ci: add scripted diff checks #1900

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7cb3d30
scripts: add commit-script-check.sh from bitcoin core
jonatack Jul 20, 2025
0432f27
ci: add scripted diff checks
jonatack Jul 20, 2025
797f95f
scripted-diff: CI should fail
jonatack Aug 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion bip-0003.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ address the evolving needs of the BIP process.

## Motivation

BIP 2 was written in 2016.
BIP 2 was written in 2017.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was gonna say, I’m pretty sure that it was 2016, but I see now that you are just testing the CI.

Sorry that I haven’t reviewed this yet.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! No worries, I'm not passing the commit range correctly yet, putting it back into draft.

This BIP revisits aspects of the BIP 2 process
that did not achieve broad adoption, reduces the judgment calls assigned to the BIP Editor role, delineates the
BIP types more clearly, and generalizes the BIP process to fit the community’s use of the repository.
Expand Down