Skip to content

fix: correct misleading ORDER_HALF comment in bip-0374 #2059

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
zeroprooff wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: correct misleading ORDER_HALF comment in bip-0374 #2059

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions bip-0374/secp256k1.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -164,10 +164,10 @@ class GE:
* infinity: True
"""

# Order of the group (number of points on the curve, plus 1 for infinity)
# Order of the group (number of points on the curve, including infinity)
ORDER = 0xFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFEBAAEDCE6AF48A03BBFD25E8CD0364141

# Number of valid distinct x coordinates on the curve.
# Half the order, used for ECDSA low-S normalization
ORDER_HALF = ORDER // 2

def __init__(self, x=None, y=None):
Expand Down