We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
There was an error while loading. Please reload this page.
2 parents e2b8c39 + 36f60a5 commit 03dd707Copy full SHA for 03dd707
CONTRIBUTING.md
@@ -178,7 +178,9 @@ language is used within pull-request comments:
178
179
- ACK means "I have tested the code and I agree it should be merged";
180
- NACK means "I disagree this should be merged", and must be accompanied by
181
- sound technical justification. NACKs without accompanying reasoning may be disregarded;
+ sound technical justification (or in certain cases of copyright/patent/licensing
182
+ issues, legal justification). NACKs without accompanying reasoning may be
183
+ disregarded;
184
- utACK means "I have not tested the code, but I have reviewed it and it looks
185
OK, I agree it can be merged";
186
- Concept ACK means "I agree in the general principle of this pull request";
0 commit comments