Merge bitcoin/bitcoin#25963: CBlockLocator: performance-move-const-arg Clang tidy fixup

MacroFake · MacroFake · commit b9361231105b · 2022-08-31T15:59:56.000+02:00
6b24dfe CBlockLocator: performance-move-const-arg Clang tidy fixups (Jon Atack) Pull request description: Fix Clang-tidy CI errors on master. See https://cirrus-ci.com/task/4806752200818688?logs=ci#L4696 for an example. ACKs for top commit: MarcoFalke: review ACK 6b24dfe vasild: ACK 6b24dfe Tree-SHA512: 7a67acf7b42da07b63fbb392236e9a7be8cf35c36e37ca980c4467fe8295c2eda8aef10f41a1e3036cd9ebece47fa957fc3256033f853bd6a97ce2ca42799a0a
diff --git a/src/chain.cpp b/src/chain.cpp
@@ -49,7 +49,7 @@ std::vector<uint256> LocatorEntries(const CBlockIndex* index)
 
 CBlockLocator GetLocator(const CBlockIndex* index)
 {
-    return CBlockLocator{std::move(LocatorEntries(index))};
+    return CBlockLocator{LocatorEntries(index)};
 }
 
 CBlockLocator CChain::GetLocator() const
diff --git a/src/primitives/block.h b/src/primitives/block.h
@@ -123,7 +123,7 @@ struct CBlockLocator
 
     CBlockLocator() {}
 
-    explicit CBlockLocator(const std::vector<uint256>& vHaveIn) : vHave(vHaveIn) {}
+    explicit CBlockLocator(std::vector<uint256>&& have) : vHave(std::move(have)) {}
 
     SERIALIZE_METHODS(CBlockLocator, obj)
     {

Original file line number	Diff line number	Diff line change
`@@ -49,7 +49,7 @@ std::vector<uint256> LocatorEntries(const CBlockIndex* index)`
`49`	`49`
`50`	`50`	`CBlockLocator GetLocator(const CBlockIndex* index)`
`51`	`51`	`{`
`52`		`- return CBlockLocator{std::move(LocatorEntries(index))};`
	`52`	`+ return CBlockLocator{LocatorEntries(index)};`
`53`	`53`	`}`
`54`	`54`
`55`	`55`	`CBlockLocator CChain::GetLocator() const`
Original file line number	Diff line number	Diff line change
`@@ -123,7 +123,7 @@ struct CBlockLocator`
`123`	`123`
`124`	`124`	`CBlockLocator() {}`
`125`	`125`
`126`		`- explicit CBlockLocator(const std::vector<uint256>& vHaveIn) : vHave(vHaveIn) {}`
	`126`	`+ explicit CBlockLocator(std::vector<uint256>&& have) : vHave(std::move(have)) {}`
`127`	`127`
`128`	`128`	`SERIALIZE_METHODS(CBlockLocator, obj)`
`129`	`129`	`{`