Skip to content

chore: bdk-ffi submodule pre-0.30.0 #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Nov 24, 2025
Merged

chore: bdk-ffi submodule pre-0.30.0 #11

Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
dfb0905
chore: bdk-ffi submodule pre-0.30.0
reez Nov 21, 2025
b876ecf
chore: format demo
reez Nov 21, 2025
694ae55
ci: pin dart sdk to 3.9.2 for stable formatting
reez Nov 21, 2025
2fcbff6
ci: scope dart format to lib/test/examples
reez Nov 21, 2025
057d705
ci: analyze only lib/test/examples
reez Nov 21, 2025
9b53534
ci: flutter demo in pipeline
reez Nov 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,8 @@ jobs:

- name: Setup Dart
uses: dart-lang/setup-dart@v1
with:
sdk: "3.9.2"

Copy link

@Johnosezele Johnosezele Nov 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

since our bdk_demo is a flutter app we'd have to install flutter in the job

      - name: Setup Flutter
        uses: subosito/flutter-action@v2
        with:
          channel: stable

- name: Install lipo (macOS)
if: matrix.os == 'macos-latest'
Expand All @@ -41,10 +43,10 @@ jobs:
run: dart pub get

Copy link

@Johnosezele Johnosezele Nov 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so then we add this before formating/analzing bdk_demo/

      - name: Pub get (bdk_demo)
        working-directory: bdk_demo
        run: flutter pub get

Copy link

@Johnosezele Johnosezele Nov 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

after the flutter pub get stepp, we can also do flutter analyze for bdk_demo/

      - name: Analyze (bdk_demo)
        working-directory: bdk_demo
        run: flutter analyze

Copy link

@Johnosezele Johnosezele Nov 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe in the future when we add widget/integration test to demo we can follow up with

      - name: Test (bdk_demo)
        working-directory: bdk_demo
        run: flutter test

- name: Format check
run: dart format --output=none --set-exit-if-changed .
run: dart format --output=none --set-exit-if-changed lib test examples

- name: Analyze
run: dart analyze --fatal-infos --fatal-warnings
run: dart analyze --fatal-infos --fatal-warnings lib test examples
Comment on lines 43 to 58
Copy link

@Johnosezele Johnosezele Nov 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

currently the workflow formats/analyzes only lib, test & examples, if we want ci to guard the demo we should add bdk_demo/lib and maybe bdk_demo/tests


- name: Run tests
run: |
Expand Down
2 changes: 1 addition & 1 deletion bdk-ffi
Open in desktop
Copy link

@Johnosezele Johnosezele Nov 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had to regenerate our bindings on this update, it was successful, I can see some new types were added

Submodule bdk-ffi updated 5 files
+20 −21 .github/ISSUE_TEMPLATE/release.md
+47 −0 CHANGELOG.md
+1 −1 bdk-android/gradle.properties
+1 −1 bdk-ffi/Cargo.toml
+8 −5 bdk-ffi/src/kyoto.rs
7 changes: 2 additions & 5 deletions bdk_demo/lib/main.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,10 +58,7 @@ class _MyHomePageState extends State<MyHomePage> {
color: _success ? Colors.green : Colors.grey,
),
const SizedBox(height: 20),
const Text(
'BDK Network Type:',
style: TextStyle(fontSize: 20),
),
const Text('BDK Network Type:', style: TextStyle(fontSize: 20)),
Text(
_networkName,
style: Theme.of(context).textTheme.headlineMedium?.copyWith(
Expand Down Expand Up @@ -105,4 +102,4 @@ class _MyHomePageState extends State<MyHomePage> {
),
);
}
}
}