Add sign / verify for arbitrary messages#139
Closed
q-src wants to merge 3 commits intobitcoindevkit:masterfrom
getlipa:feature/msgsig
Closed
Add sign / verify for arbitrary messages#139q-src wants to merge 3 commits intobitcoindevkit:masterfrom getlipa:feature/msgsig
q-src wants to merge 3 commits intobitcoindevkit:masterfrom
getlipa:feature/msgsig
Conversation
Closed
Member
|
This looks cool! I'll take a look and it might be something we want to have in |
Member
|
@q-src we've discussed this in 2 dev calls and think it might be valuable to have as part of the core Rust bitcoindevkit. Are you interested in opening a PR to add the feature right in bdk? Also our dev calls are open and bi-weekly, so if ever that's something you're interested in joining we'd love to have you. You can join our Discord and you'll find all the info there. Cheers! |
Author
|
Thanks for the feedback @thunderbiscuit. I opened a PR at bdk: bitcoindevkit/bdk#601 Sure, I am happy to join the dev calls :) |
Member
Member
|
Closing in favour of bitcoindevkit/bdk#601. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support for the creation of signatures of arbitrary messages and their verification. A PR for bdk-kotlin will follow.
Signatures can be created using a given
wif,prvorxprv. They can be verified using apub,xpuboraddress.Since these are my very first steps with Rust, please take a closer look at the coding style as well.