Skip to content

Add coin selection to tx_builder #821

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Add coin selection to tx_builder #821

wants to merge 2 commits into from

Conversation

thunderbiscuit
Copy link
Member

This one is particularly ugly. This is because the TxBuilder is generic in its coin selection algo, but we were only using 1 version of this generic and TxBuilder so far, so everything was easy.

I do think this could be cleaned up. I just wanted to run the tests and show where I'm at.

Changelog notice

Checklists

All Submissions:

  • I've signed all my commits
  • I followed the contribution guidelines
  • I ran cargo fmt and cargo clippy before committing

New Features:

  • I've added tests for the new feature
  • I've added docs for the new feature

Bugfixes:

  • This pull request breaks the existing API
  • I've added tests to reproduce the issue which are now passing
  • I'm linking the issue being fixed by this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
BDK-Bindings
Status: No status
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@thunderbiscuit