refactor: descriptor errors instead of panicking on invalid fingerprints#880
Merged
reez merged 1 commit intobitcoindevkit:masterfrom Oct 20, 2025
Merged
refactor: descriptor errors instead of panicking on invalid fingerprints#880reez merged 1 commit intobitcoindevkit:masterfrom
reez merged 1 commit intobitcoindevkit:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes the four descriptor constructors to return and map invalid fingerprints instead of unwrapping.
People using bindings will now get typed error they can handle instead of a possible panic.
Previously constructors handed back nothing on malformed input because they crashed so now they surface concrete error.
Notes to the reviewers
Changelog notice
Checklists
All Submissions:
cargo fmtandcargo clippybefore committingNew Features:
Bugfixes: