Skip to content

feat: Add method to get block by hash for esplora#936

Merged
thunderbiscuit merged 1 commit intobitcoindevkit:masterfrom
ItoroD:esplora-client-methods
Jan 15, 2026
Merged

feat: Add method to get block by hash for esplora#936
thunderbiscuit merged 1 commit intobitcoindevkit:masterfrom
ItoroD:esplora-client-methods

Conversation

@ItoroD
Copy link
Collaborator

@ItoroD ItoroD commented Jan 13, 2026

Description

#662 I am taking a look at the highlighted APIs here and bringing those in.

Notes to the reviewers

This PR seems to be the last mentioned one for esplora. After looking at those named in the comments that are not in already, I will also take you more general look to see if there are other very useful methods that people need.

Documentation

Block: https://docs.rs/bitcoin/0.32.7/bitcoin/blockdata/block/struct.Block.html

Checklists

All Submissions:

  • I've signed all my commits
  • I followed the contribution guidelines
  • I ran cargo fmt and cargo clippy before committing
  • I've added a changelog in the next release tracking issue (see example)
  • I've linked the relevant upstream docs or specs above

New Features:

  • I've added tests for the new feature
  • I've added docs for the new feature

Copy link
Collaborator

@reez reez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 25ecc3b

LGTM!

@ItoroD ItoroD force-pushed the esplora-client-methods branch from 25ecc3b to 2de7ab9 Compare January 14, 2026 15:28
@ItoroD
Copy link
Collaborator Author

ItoroD commented Jan 14, 2026

ACK 25ecc3b

LGTM!

Thanks for the review! I just Rebased

Copy link
Member

@thunderbiscuit thunderbiscuit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TestedACK 2de7ab9. Nice little addition with the Block type!

Do you mind adding this to the changelog issue as well? This release is going to be packed with goodies!

@thunderbiscuit thunderbiscuit merged commit af2475e into bitcoindevkit:master Jan 15, 2026
4 checks passed
@ItoroD
Copy link
Collaborator Author

ItoroD commented Jan 15, 2026

@thunderbiscuit Sure! Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants