feat: Add method to get block by hash for esplora#936
Merged
thunderbiscuit merged 1 commit intobitcoindevkit:masterfrom Jan 15, 2026
Merged
feat: Add method to get block by hash for esplora#936thunderbiscuit merged 1 commit intobitcoindevkit:masterfrom
thunderbiscuit merged 1 commit intobitcoindevkit:masterfrom
Conversation
c4b761e to
25ecc3b
Compare
reez
approved these changes
Jan 13, 2026
25ecc3b to
2de7ab9
Compare
Collaborator
Author
Thanks for the review! I just Rebased |
thunderbiscuit
approved these changes
Jan 15, 2026
Member
thunderbiscuit
left a comment
There was a problem hiding this comment.
TestedACK 2de7ab9. Nice little addition with the Block type!
Do you mind adding this to the changelog issue as well? This release is going to be packed with goodies!
2de7ab9 to
af2475e
Compare
Collaborator
Author
|
@thunderbiscuit Sure! Thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
#662 I am taking a look at the highlighted APIs here and bringing those in.
Notes to the reviewers
This PR seems to be the last mentioned one for esplora. After looking at those named in the comments that are not in already, I will also take you more general look to see if there are other very useful methods that people need.
Documentation
bdk_walletbitcoinuniffiBlock: https://docs.rs/bitcoin/0.32.7/bitcoin/blockdata/block/struct.Block.html
Checklists
All Submissions:
cargo fmtandcargo clippybefore committingNew Features: