Validate add_foreign_utxo inputs at method boundary#944
Open
reez wants to merge 2 commits intobitcoindevkit:masterfrom
Open
Validate add_foreign_utxo inputs at method boundary#944reez wants to merge 2 commits intobitcoindevkit:masterfrom
add_foreign_utxo inputs at method boundary#944reez wants to merge 2 commits intobitcoindevkit:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR aligns
bdk-ffiTxBuilder::add_foreign_utxowith upstreambdk_walletboundary validation behavior.add_foreign_utxo(instead of deferring tofinish), behavior now matches method’s documented error semanticstest_add_foreign_utxo_missing_witness_datato assert failure atadd_foreign_utxoand remove wallet sync/recipient setup that is no longer needed for this boundary testNotes to the reviewers
Directly related to comment: #928 (comment)
I implemented a broader version of my original suggestion by aligning
add_foreign_utxowith full upstream boundary validation, so all documented input errors are returned immediately instead of being deferred tofinish().Documentation
bdk_walletbitcoinuniffiChecklists
All Submissions:
cargo fmtandcargo clippybefore committingNew Features:
Bugfixes: