feat: Expose miniscript has_wildcard and sanity_check#945
Open
ItoroD wants to merge 1 commit intobitcoindevkit:masterfrom
Open
feat: Expose miniscript has_wildcard and sanity_check#945ItoroD wants to merge 1 commit intobitcoindevkit:masterfrom
has_wildcard and sanity_check#945ItoroD wants to merge 1 commit intobitcoindevkit:masterfrom
Conversation
has_wildcard and sanity_check
Collaborator
Author
|
I think the sanity method check is great! I wonder what other kinds of things it could catch. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adding these based off of #687
Notes to the reviewers
Documentation
https://docs.rs/miniscript/latest/miniscript/descriptor/enum.Descriptor.html#method.has_wildcard
https://docs.rs/miniscript/latest/miniscript/descriptor/enum.Descriptor.html#method.sanity_check
bdk_walletbitcoinuniffiOther:
Checklists
All Submissions:
cargo fmtandcargo clippybefore committingNew Features: