Continue cleaning up our existing tests #17
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thunderbiscuit
force-pushed
the
test/more-unit-tests
branch
from
b68f7cc to
aa8ac03
Compare
Collaborator
|
This is great! I particularly like the use of sentences for the test methods. Makes it really clear |
ItoroD
approved these changes
Sep 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This complete my cleanup of our existing tests. Wow the more I look at those the more I realize how little our coverage is. After this is merged, further work can be done to then increase the test coverage (this one is more about refactoring what we have: renaming the old "Offline" convention, using sentences to name tests with back ticks, etc.)
The persistence test still uses the old descriptors because the database committed is there, but it should also eventually be updated to make use of our new descriptors in
Constants.kt.