-
Notifications
You must be signed in to change notification settings - Fork 2
More and better tests #18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
17d51bd
to
9c1a61a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Your additional tests for the multipath work well with master (bdk-ffi)!
I have noted you have more things you will like to add here 👍. Looking good so far.
|
||
@Test | ||
fun `Descriptors can be created from multipath public descriptor string`() { | ||
Descriptor("tr($TEST_EXTENDED_PUBKEY/<0;1>/*)", Network.REGTEST) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a nit.
For completeness sake, will we want to add the other test networks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done!
a23c104
to
6d582c1
Compare
@ItoroD this is ready for final review. I have updated the submodule to the latest commit on master for bdk-ffi so that the tests for the 2 new APIs can work. Note that I did not fix the Kyoto example in this PR, so the CI fails but only on that. |
baf1d0e
to
147539d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK 147539d
PR #22 fixes the kyoto sample error. I also updated submodule to latest from master just like you have here commit: |
Yeah I think merging yours first makes more sense. I'll rebase this after. Thanks for the review! |
147539d
to
568d730
Compare
I'll keep this one open until some of my bdk-ffi PRs are in and I'll add tests for them here.
The first commit on this PR streamlines our use of extended keys public and private. I introduced two mnemonics:
Which are then used to produce the keys, descriptors, ect.
Todo
Wallet::create_single
method bdk-ffi#825Wallet::create_from_two_path_descriptor
constructor bdk-ffi#847