Skip to content

Conversation

thunderbiscuit
Copy link
Member

@thunderbiscuit thunderbiscuit commented Sep 4, 2025

I'll keep this one open until some of my bdk-ffi PRs are in and I'll add tests for them here.

The first commit on this PR streamlines our use of extended keys public and private. I introduced two mnemonics:

const val MNEMONIC_AWESOME = "awesome awesome awesome awesome awesome awesome awesome awesome awesome awesome awesome awesome"
const val MNEMONIC_ALL = "all all all all all all all all all all all all"

Which are then used to produce the keys, descriptors, ect.

Todo

Copy link
Collaborator

@ItoroD ItoroD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your additional tests for the multipath work well with master (bdk-ffi)!

I have noted you have more things you will like to add here 👍. Looking good so far.


@Test
fun `Descriptors can be created from multipath public descriptor string`() {
Descriptor("tr($TEST_EXTENDED_PUBKEY/<0;1>/*)", Network.REGTEST)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a nit.

For completeness sake, will we want to add the other test networks

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done!

@thunderbiscuit
Copy link
Member Author

thunderbiscuit commented Sep 8, 2025

@ItoroD this is ready for final review. I have updated the submodule to the latest commit on master for bdk-ffi so that the tests for the 2 new APIs can work.

Note that I did not fix the Kyoto example in this PR, so the CI fails but only on that.

Copy link
Collaborator

@ItoroD ItoroD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 147539d

@ItoroD
Copy link
Collaborator

ItoroD commented Sep 9, 2025

Note that I did not fix the Kyoto example in this PR, so the CI fails but only on that.

PR #22 fixes the kyoto sample error. I also updated submodule to latest from master just like you have here commit: 53d4986. You can choose to merge that and rebase this PR. Or vice versa. Fine with either really.

@thunderbiscuit
Copy link
Member Author

Yeah I think merging yours first makes more sense. I'll rebase this after. Thanks for the review!

@thunderbiscuit thunderbiscuit merged commit 568d730 into master Sep 9, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants